Skip to content

potential fix for httpupgrade+trojan#3475

Closed
mmmray wants to merge 1 commit intoXTLS:mainfrom
mmmray:httpupgrade-read0
Closed

potential fix for httpupgrade+trojan#3475
mmmray wants to merge 1 commit intoXTLS:mainfrom
mmmray:httpupgrade-read0

Conversation

@mmmray
Copy link
Contributor

@mmmray mmmray commented Jun 25, 2024

#3473 (comment)

did not reproduce locally, just saw xq have an issue in tg

@yuhan6665
Copy link
Member

Looks good. BTW there is a new issue with the unit test that causing blocking (dead lock) for 1 hour.

  • Test_listenHTTPUpgradeAndDial
  • Test_listenSHAndDial

Can someone take a look? If not I can do..

@mmmray
Copy link
Contributor Author

mmmray commented Jun 25, 2024

it seems this fix didn't help, and I don't know how to trigger the issue anyway.

I will check the test failures within the next day

@mmmray mmmray closed this Jun 25, 2024
@mmmray mmmray deleted the httpupgrade-read0 branch June 25, 2024 15:15
@RPRX
Copy link
Member

RPRX commented Jun 27, 2024

不配置 fallbacks 时,VLESS 入站会继续 Read,Trojan 入站不会

当然最好还是修改 HTTPUpgrade 的代码防止 Read 出 0

@mmmray
Copy link
Contributor Author

mmmray commented Jun 27, 2024

I will bring back this PR if somebody manages to reproduce the issue. I think it may be that Trojan only has an issue with the initial upload, but not the initial download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants