Skip to content

Conversation

@LeonPev
Copy link

@LeonPev LeonPev commented Jun 16, 2023

added sqlcommenter output to the sql.conn.query span for compatibility with js and py packages that have similar behavior

@LeonPev LeonPev requested a review from XSAM as a code owner June 16, 2023 12:37
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (eb15273) 80.5% compared to head (ab7f8ba) 80.6%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #177   +/-   ##
=====================================
  Coverage   80.5%   80.6%           
=====================================
  Files         13      13           
  Lines        716     717    +1     
=====================================
+ Hits         577     578    +1     
  Misses       115     115           
  Partials      24      24           
Impacted Files Coverage Δ
conn.go 78.3% <100.0%> (+0.1%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LeonPev, Thanks for the PR.

Could you please attach examples and screenshots that shows SQL comment in spans?

Please also change ExecContext and PrepareContext for consistency. And, update tests and CHANGELOG.md to reflect this change.

@XSAM
Copy link
Owner

XSAM commented Jul 8, 2023

Hi @LeonPev, do you still have an interest in implementing this? I can take this if you are not interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants