Skip to content
This repository was archived by the owner on Aug 11, 2024. It is now read-only.

Comments

Change requests/sdk installer#176

Merged
StephenHodgson merged 2 commits intofix/guidregenerationfrom
change-requests/sdk-installer
May 8, 2020
Merged

Change requests/sdk installer#176
StephenHodgson merged 2 commits intofix/guidregenerationfrom
change-requests/sdk-installer

Conversation

@StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented May 7, 2020

Overview

updated sdk packages installer to be more similar to the other installers in other packages

XRTK/com.xrtk.core#571

Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will retest against dev once merged

@StephenHodgson StephenHodgson merged commit 095591c into fix/guidregeneration May 8, 2020
@StephenHodgson StephenHodgson deleted the change-requests/sdk-installer branch May 8, 2020 15:52
StephenHodgson added a commit that referenced this pull request May 8, 2020
* Updated GUID regeneration for SDK

* Updated package check to only proceed if both Profiles and prefabs are copied successfully

* Added check to unset prefs if any of the copies fails

* Change requests/sdk installer (#176)

* make sdk installer more like the others

* updated menu validation

Co-authored-by: Stephen Hodgson <[email protected]>
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
* Updated GUID regeneration for SDK

* Updated package check to only proceed if both Profiles and prefabs are copied successfully

* Added check to unset prefs if any of the copies fails

* Change requests/sdk installer (#176)

* make sdk installer more like the others

* updated menu validation

Co-authored-by: Stephen Hodgson <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants