This repository was archived by the owner on Aug 11, 2024. It is now read-only.
clickable services without having to open foldout#848
Merged
StephenHodgson merged 10 commits intodevelopmentfrom Jun 4, 2021
Merged
clickable services without having to open foldout#848StephenHodgson merged 10 commits intodevelopmentfrom
StephenHodgson merged 10 commits intodevelopmentfrom
Conversation
Contributor
Author
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
…tem profile from a controller data provider updated service clickablility when no profile is required
StephenHodgson
added
Ready for review
StephenHodgson
added
Blocked
and removed
Ready for review
StephenHodgson
added a commit
to XRTK/com.xrtk.lumin
that referenced
this pull request
Jun 4, 2021
# XRTK - Mixed Reality Toolkit Pull Request ## Overview added lumin spatial mesh observer profile ## Related Submodule Changes - XRTK/com.xrtk.core#848
StephenHodgson
added a commit
to XRTK/com.xrtk.wmr
that referenced
this pull request
Jun 4, 2021
# XRTK - Mixed Reality Toolkit Pull Request ## Overview Added WMR spatial mesh observer profile ## Related Submodule Changes - XRTK/com.xrtk.core#848
StephenHodgson
added
the
Ready for review
StephenHodgson
added a commit
to XRTK/Examples
that referenced
this pull request
Jun 4, 2021
# XRTK - Mixed Reality Toolkit Pull Request ## Overview Updated demo profiles ## Related Submodule Changes <!-- Include any submodule related Pull Request links here --> - XRTK/com.xrtk.core#848
FejZa
approved these changes
Jun 4, 2021
Contributor
FejZa
left a comment
FejZa
left a comment
There was a problem hiding this comment.
Looks good. I'd like Simon to check as well. Not sure how this happened but looks to me like two people invested time in addressing the same thing and we ended up with two solutions.
SimonDarksideJ
approved these changes
Jun 4, 2021
Contributor
|
It is frustrating that several paths were developed for the same solution. We just need to get better/more serious about feeding back into feature request tasks to avoid duplication. (and not just dismiss because we aren't interested) We need to evolve requirements about Requests with any relevant views with Constructive feedback (solutions not dismissals) |
Contributor
Author
|
Understandable. From a purely objective criticism, I was worried the changes were too broad without adequately addressing all the services and data providers. The changes here are targeted and doesn't require us to add additional classes or icon assets. |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Jun 11, 2021
* clickable services without having to open foldout * updated visual style a bit * fixed a misc bug in input system inspector * fixed an invalid cast excpetion when navigating back to the input system profile from a controller data provider updated service clickablility when no profile is required * a few tweaks to the spacing * fixed a NRE when assigning a profile to an expended service reference updated profiles * updated submodules * updated examples submodule
XRTK-Build-Bot
pushed a commit
to XRTK/com.xrtk.wmr
that referenced
this pull request
Jun 11, 2021
# XRTK - Mixed Reality Toolkit Pull Request ## Overview Added WMR spatial mesh observer profile ## Related Submodule Changes - XRTK/com.xrtk.core#848
XRTK-Build-Bot
pushed a commit
to XRTK/com.xrtk.lumin
that referenced
this pull request
Jun 11, 2021
# XRTK - Mixed Reality Toolkit Pull Request ## Overview added lumin spatial mesh observer profile ## Related Submodule Changes - XRTK/com.xrtk.core#848
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Added the ability to click on services to open their configurations with less clicks. should work automatically for all services and data providers.Changes
IMixedRealityInputDataProviderproperty was closed.Submodule Changes