This repository was archived by the owner on Aug 11, 2024. It is now read-only.
Merged
Conversation
StephenHodgson
added
the
Ready for review
SimonDarksideJ
approved these changes
Apr 22, 2021
SimonDarksideJ
suggested changes
Apr 22, 2021
Contributor
SimonDarksideJ
left a comment
SimonDarksideJ
left a comment
There was a problem hiding this comment.
Actually, can we get some unit tests for these updates and general rest tests, including auth
Contributor
Author
|
Unit tests don't work with async afaik |
Contributor
Author
|
Also, what remote resources do we have to perform the tests against? |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Apr 23, 2021
* updated rest api * fixed some formatting * sorted some methods * Added progress callbacks * updated license * sorted out all the signatures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Modernized the Rest APIs a bit.
IProgresscallbacksDownloadTextureAsyncDownladAudioClipAsyncDownloadAssetBundleAsync