Skip to content

Conversation

@maria-robobug
Copy link
Contributor

@maria-robobug maria-robobug commented Nov 5, 2025

Fixes the following build error, which was triggered by the Redocly upgrade to 0.126.0:

[2025-10-30 20:49:06:875]:
[error] [1] Runtime error: Cannot destructure property 'blogPosts' of 't(...)' as it is undefined.
at ./@l10n/es-ES/blog/index.page.tsx
[2025-10-30 20:49:06:875]:
[error] [2] Runtime error: Cannot destructure property 'codeSamples' of 't(...)' as it is undefined.
at ./@l10n/es-ES/resources/code-samples.page.tsx
[2025-10-30 20:49:06:876]:
[error] Need to fix 2 runtime error(s) in React pages
[2025-10-30 20:49:07:126]:
fatal error: all goroutines are asleep - deadlock!
[2025-10-30 20:49:07:128]:
goroutine 1 [chan receive]:
github.com/evanw/esbuild/internal/helpers.(*ThreadSafeWaitGroup).Wait(...)
	github.com/evanw/esbuild/internal/helpers/waitgroup.go:36
main.runService.func2()
...

The upgrade also broke the Spanish version of these pages (which this change should fix):

This is the fix suggested by the Redocly team. Some context from discussion with Redocly:

After some investigation I found that this is not exactly a bug but it's something we can definitely improve.
For now, these errors are valid (though the paths are misleading because there are no such physical files).
To fix this, you need to update the @theme/plugins/blog-posts.js and @theme/plugins/code-samples.js files and add one more call of actions.addRouteSharedData for the /es-es path the same way it's duplicated for the /ja path (see screenshot).
Both the Blog page and Code Samples page for the Spanish locale are broken right now on 0.122.3. We introduced validation of React pages rendering in 0.126.0 and that is where these errors come from.

Copy link
Collaborator

@oeggert oeggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. No build errors and I can access the preview site.

This should close out #3373

@maria-robobug maria-robobug merged commit d6b55ab into master Nov 6, 2025
4 of 5 checks passed
@maria-robobug maria-robobug deleted the build-fix branch November 6, 2025 09:31
@maria-robobug maria-robobug mentioned this pull request Nov 6, 2025
@maria-robobug maria-robobug added bug Typo or other small documentation error redocly Issues with the Redocly toolchain labels Nov 6, 2025
@maria-robobug maria-robobug self-assigned this Nov 6, 2025
@maria-robobug maria-robobug moved this to Done in XRPL Docs Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Typo or other small documentation error redocly Issues with the Redocly toolchain

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants