Allow retry policy to run on GET requests#867
Merged
XAMPPRocky merged 1 commit intoMar 28, 2026
Conversation
Right now, it seems that GET requests do not end up hitting the retry middleware. This is presumably because this one line returns None when there is no buffered body. Just create an empty body if we get None back from try_clone, and allow the retry policy to take effect.
Owner
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, it seems that GET requests do not end up hitting the retry middleware. This is presumably because this one line returns None when there is no buffered body. Just create an empty body if we get None back from try_clone, and allow the retry policy to take effect.