Skip to content

Use Option<AuthorAssociation> over String in Issue struct#822

Merged
XAMPPRocky merged 1 commit into
XAMPPRocky:mainfrom
maflcko:author_association
Nov 6, 2025
Merged

Use Option<AuthorAssociation> over String in Issue struct#822
XAMPPRocky merged 1 commit into
XAMPPRocky:mainfrom
maflcko:author_association

Conversation

@maflcko
Copy link
Copy Markdown
Contributor

@maflcko maflcko commented Nov 6, 2025

This is more type-safe. Also, according to the response schema (https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#get-an-issue), the field is not required. Only the following are required:

  "required": [
    "assignee",
    "closed_at",
    "comments",
    "comments_url",
    "events_url",
    "html_url",
    "id",
    "node_id",
    "labels",
    "labels_url",
    "milestone",
    "number",
    "repository_url",
    "state",
    "locked",
    "title",
    "url",
    "user",
    "created_at",
    "updated_at"
  ]

So, make it optional as well.

@dmgorsky
Copy link
Copy Markdown
Collaborator

dmgorsky commented Nov 6, 2025

lgtm

@XAMPPRocky XAMPPRocky merged commit edc6cde into XAMPPRocky:main Nov 6, 2025
20 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 6, 2025
@maflcko maflcko deleted the author_association branch April 9, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants