fix: don't capture backtraces by default#710
Merged
Merged
Conversation
Call `Backtrace::capture()` instead of the `Backtrace::generate()` method provided by snafu. This disables backtrace capturing unless either the `RUST_BACKTRACE` or `RUST_LIB_BACKTRACE` environment variables are set at runtime. Refs: XAMPPRocky#649
Owner
|
Thank you for your PR! |
Closed
dmgorsky
pushed a commit
to dmgorsky/octocrab
that referenced
this pull request
Oct 8, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
Backtrace::capture()instead of theBacktrace::generate()method provided by snafu. This disables backtrace capturing unless either theRUST_BACKTRACEorRUST_LIB_BACKTRACEenvironment variables are set at runtime.This completely disables backtrace capturing, not just displaying the backtrace though, so if the backtrace is too important to disable it completely by default, I could also refactor this PR to change the display behavior - maybe through a feature flag letting consumers decide if they want to work with backtraces or not.
Closes: #649