Skip to content

Unify diff entry models#624

Merged
XAMPPRocky merged 2 commits into
XAMPPRocky:mainfrom
flying-sheep:fix-diff-entry
Apr 4, 2024
Merged

Unify diff entry models#624
XAMPPRocky merged 2 commits into
XAMPPRocky:mainfrom
flying-sheep:fix-diff-entry

Conversation

@flying-sheep
Copy link
Copy Markdown
Contributor

@flying-sheep flying-sheep commented Apr 4, 2024

Fixes #623

IDK which one would the best “source of truth”.

Maybe commits would make most sense? commits and repos share a lot of structs, I think. But commits::GitCommitObject already uses a bunch of things from repos

@XAMPPRocky
Copy link
Copy Markdown
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit 67c316f into XAMPPRocky:main Apr 4, 2024
@github-actions github-actions Bot mentioned this pull request Mar 29, 2024
@flying-sheep flying-sheep deleted the fix-diff-entry branch April 5, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model bug in DiffEntry: Submodules have "blob_url": null and "raw_url": null

2 participants