Add follow-redirect feature#469
Merged
Merged
Conversation
XAMPPRocky
reviewed
Oct 15, 2023
Comment on lines
+58
to
+59
| #[tokio::test] | ||
| async fn should_return_page_with_users() { |
Owner
There was a problem hiding this comment.
Suggested change
| #[tokio::test] | |
| async fn should_return_page_with_users() { | |
| #[tokio::test] | |
| #[cfg_attr(not(feature = "follow-redirect"), ignore)] | |
| async fn should_return_page_with_users() { |
Owner
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #468
I am new to
tower, so nits are more than welcome.I made the new layer a configurable feature, since that seemed to be the pattern.
Also, I couldn't tell whether the layers were added in a particular order. I tried to add the new layer in a place that I thought made sense.