simple_connectivity v0.0.1 => connectivity v2.0.0

[brunobowden]

• Closes Connectivity no location permissions proper fix #1532
• Replace 3rd party simple_connectivity with Google connectivity package
• New version removes dependency on locations permission:
  • https://pub.dev/packages/connectivity/changelog#200
• compileSdkVersion 29 - matching targetSdk and Flutter packages

Screenshots

Screenshots

Add any relevant before/after screenshots here

How did you test the change?

Will test later with device turning on and off wifi access

• iOS Simulator
• iOS Device
• Android Simulator
• Android Device
• curl to a dev App Engine server
• other, please describe

Checklist:

• Followed the Contributor Guidelines and verified that all contributions are properly licensed pursuant to the LICENSE.

[brunobowden]

FYI @Mohit020888 - see if you can figure out a good way to test this

[theswerd]

LGTM

gotta re-review because of CI Errors

[brunobowden]

@cyanglaz - thanks for the updating Connectivity to v2.0.0. You put a lot of care in to the deprecation message, v2.0.0 as a breaking change and so on. Sorry to trouble you further but I'd appreciate if you could take a look at this CI issue I'm seeing after the upgrade:

The conflict was with PR flutter/plugins#3042 where compileSdkVersion 29 was added in connectivity v0.4.9+5. I think the package may be fine but it's causing some interaction with our CI. Our CI uses Java 12 - see workflow. After the update, it fails on a Java warning for source value 7 is obsolete. That same warning occurred with connectivity v0.4.9+3 but it didn't fail the CI build.

I didn't want to take up too much of your time but I'd appreciate your perspective if you had any insights.

CI Build Error

Running Gradle task 'assembleRelease'...                        
warning: [options] source value 7 is obsolete and will be removed in a future release
warning: [options] target value 7 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
error: warnings found and -Werror specified
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':connectivity:compileReleaseJavaWithJavac'.

[cyanglaz]

I'm not too familiar with Android stuff. But it looks like you could switch to android 29 on ci?

[brunobowden]

@cyanglaz - I changed compileSdkVersion from 28 to 29 as part of the PR. Still looking in to this.

[theswerd]

LGTM

[brunobowden]

@yukuairoy - needs your approval too

[brunobowden]

@cyanglaz - figured out the problem was that the connectivity plugin recently started treating all warnings as errors.... so a warning about Java 7 target becoming obsolete now causes the build to fail. Temporary workaround is to downgrade to Java 11 environment (which doesn't treat Java 7 target as obsolete). Proper fix is Java 8 target for all Flutter plugins that have the Werror flag: flutter/plugins#3216