PHP.wasm: Report both the source and target path on failure #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures the target path of `php.mv(source, target)` is included in the error message when the move fails. This makes for a better developer experience and easier debugging. ## Testing instructions Confirm the CI tests pass – this change is accomianied by updated tests.
Contributor
|
This will definitely make debugging easier in the long run. 👍 approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures the target path of
php.mv(source, target)is included in the error message when the move fails. This makes for a better developer experience and easier debugging.Testing instructions
Confirm the CI tests pass – this change is accomianied by updated tests.