CI: Check if both CJS and ESM builds succeeded #876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `test:esmcjs` check to GitHub CI, as it was missing. Many Playground modules are built both to ES Modules for the browser and to CommonJS modules for Node.js. The `test:esmcjs` check runs after the build process and tries to both `import` and `require` the built modules in Node.js to confirm both forms can be used. This PR also fixes a bug in that check to ensure both the `import` and `require` test scripts actually run. ## Testing instructions Confirm the CI build job is green and confirm the run included the `test:esmcjs` check.
adamziel
added
[Type] Enhancement
This was referenced Dec 17, 2023
adamziel
force-pushed
the
trunk
branch
2 times, most recently
from
680cd19 to
2e376d2
Compare
Collaborator
Author
|
Superseded by @bgrgicak work. We now have a CI smoke tests for both builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
test:esmcjscheck to GitHub CI, as it was missing.Many Playground modules are built both to ES Modules for the browser and to CommonJS modules for Node.js. The
test:esmcjscheck runs after the build process and tries to bothimportandrequirethe built modules in Node.js to confirm both forms can be used.This PR also fixes a bug in that check to ensure both the
importandrequiretest scripts actually run.Testing instructions
Confirm the CI build job is green and confirm the run included the
test:esmcjscheck.Extracted from #851.