Skip to content

Abilities API: Add the initial core abilities and categories registration. #10411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

Abilities API: Add the initial core abilities and categories registration. #10411

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6debd58
Add: Core abiltiies registration.
jorgefilipecosta Oct 23, 2025
0a15be1
correct version field
jorgefilipecosta Oct 24, 2025
9427ec6
lint fix
jorgefilipecosta Oct 24, 2025
ca04081
fix wpRegisterAbility tests
jorgefilipecosta Oct 24, 2025
fd17d01
additional test fixes
jorgefilipecosta Oct 24, 2025
ec22568
in progress test fixes
jorgefilipecosta Oct 24, 2025
16d94b8
in progress test fixes
jorgefilipecosta Oct 24, 2025
ec261bb
middle most tests working
jorgefilipecosta Oct 24, 2025
bbc0ae2
one failure
jorgefilipecosta Oct 24, 2025
6a5562c
fix remaning test case
jorgefilipecosta Oct 24, 2025
527bc40
Update tests/phpunit/tests/abilities-api/wpCoreAbilities.php
jorgefilipecosta Oct 24, 2025
20c7ec3
Update src/wp-includes/abilities/wp-core-abilities.php
jorgefilipecosta Oct 24, 2025
9269d56
test fixes different appraoch
jorgefilipecosta Oct 24, 2025
0335699
Fix abilities API tests without test-specific changes
jorgefilipecosta Oct 24, 2025
b389659
add ticket mark to new tests
jorgefilipecosta Oct 24, 2025
54b48d6
apply test feedback
jorgefilipecosta Oct 24, 2025
688019f
remove duplicate variable
jorgefilipecosta Oct 25, 2025
1ab6019
remove overprotective unnecessary check
jorgefilipecosta Oct 25, 2025
c2d1b92
Add since tag missed on set_up_before_class
jorgefilipecosta Oct 25, 2025
a9997d7
make test names match ability names they are testing
jorgefilipecosta Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/phpunit/tests/abilities-api/wpAbilitiesRegistry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ public function set_up(): void {
wp_unregister_ability_category( $ability_category->get_slug() );
}

// Remove core registration action to prevent re-registration.
remove_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );

// Fire the init hook to allow test ability category registration.
do_action( 'wp_abilities_api_categories_init' );
wp_register_ability_category(
Expand Down Expand Up @@ -92,6 +95,10 @@ public function tear_down(): void {
// Clean up registered test ability category.
wp_unregister_ability_category( 'math' );

// Re-add core registration action and re-register core categories.
add_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );
do_action( 'wp_abilities_api_categories_init' );

parent::tear_down();
}

Expand Down
7 changes: 7 additions & 0 deletions tests/phpunit/tests/abilities-api/wpAbility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ public function set_up(): void {
wp_unregister_ability_category( $ability_category->get_slug() );
}

// Remove core registration action to prevent re-registration.
remove_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );

// Fire the init hook to allow test ability category registration.
do_action( 'wp_abilities_api_categories_init' );
wp_register_ability_category(
Expand Down Expand Up @@ -64,6 +67,10 @@ public function tear_down(): void {
// Clean up registered test ability category.
wp_unregister_ability_category( 'math' );

// Re-add core registration action and re-register core categories.
add_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );
do_action( 'wp_abilities_api_categories_init' );

parent::tear_down();
}

Expand Down
7 changes: 7 additions & 0 deletions tests/phpunit/tests/abilities-api/wpRegisterAbility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ public function set_up(): void {
wp_unregister_ability_category( $ability_category->get_slug() );
}

// Remove core registration action to prevent re-registration.
remove_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );

// Fire the init hook to allow test ability category registration.
do_action( 'wp_abilities_api_categories_init' );
wp_register_ability_category(
Expand Down Expand Up @@ -102,6 +105,10 @@ public function tear_down(): void {
// Clean up registered test ability category.
wp_unregister_ability_category( 'math' );

// Re-add core registration action and re-register core categories.
add_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );
do_action( 'wp_abilities_api_categories_init' );

parent::tear_down();
}

Expand Down
4 changes: 4 additions & 0 deletions tests/phpunit/tests/abilities-api/wpRegisterAbilityCategory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ public function tear_down(): void {
wp_unregister_ability_category( $ability_category->get_slug() );
}

// Re-add core registration action and re-register core categories.
add_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );
do_action( 'wp_abilities_api_categories_init' );

parent::tear_down();
}

Expand Down
9 changes: 8 additions & 1 deletion tests/phpunit/tests/rest-api/wpRestAbilitiesV1CategoriesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class Tests_REST_API_WpRestAbilitiesV1CategoriesController extends WP_UnitTestCa
protected static $admin_user_id;

/**
* Test subscriber user ID.
* Test subscriber user ID.x
*
* @var int
*/
Expand Down Expand Up @@ -67,6 +67,9 @@ public function set_up(): void {
wp_unregister_ability_category( $ability_category->get_slug() );
}

// Remove core registration action to prevent re-registration.
remove_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );

// Initialize the API and register test ability categories.
do_action( 'wp_abilities_api_categories_init' );
$this->register_test_ability_categories();
Expand All @@ -88,6 +91,10 @@ public function tear_down(): void {
wp_unregister_ability_category( $ability_category->get_slug() );
}

// Re-add core registration action and re-register core categories.
add_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );
do_action( 'wp_abilities_api_categories_init' );

global $wp_rest_server;
$wp_rest_server = null;

Expand Down
9 changes: 9 additions & 0 deletions tests/phpunit/tests/rest-api/wpRestAbilitiesV1ListController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ public function set_up(): void {
wp_unregister_ability_category( $ability_category->get_slug() );
}

// Remove core registration actions to prevent re-registration.
remove_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );
remove_action( 'wp_abilities_api_init', 'wp_register_core_abilities' );

// Initialize Abilities API.
do_action( 'wp_abilities_api_init' );
$this->register_test_abilities();
Expand All @@ -98,6 +102,11 @@ public function tear_down(): void {
wp_unregister_ability( $ability->get_name() );
}

// Re-add core registration actions and re-register core abilities.
add_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );
add_action( 'wp_abilities_api_init', 'wp_register_core_abilities' );
do_action( 'wp_abilities_api_init' );

// Reset REST server
global $wp_rest_server;
$wp_rest_server = null;
Expand Down
9 changes: 9 additions & 0 deletions tests/phpunit/tests/rest-api/wpRestAbilitiesV1RunController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ public function set_up(): void {
wp_unregister_ability_category( $ability_category->get_slug() );
}

// Remove core registration actions to prevent re-registration.
remove_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );
remove_action( 'wp_abilities_api_init', 'wp_register_core_abilities' );

// Initialize Abilities API.
do_action( 'wp_abilities_api_init' );
$this->register_test_abilities();
Expand All @@ -109,6 +113,11 @@ public function tear_down(): void {
wp_unregister_ability( $ability->get_name() );
}

// Re-add core registration actions and re-register core abilities.
add_action( 'wp_abilities_api_categories_init', 'wp_register_core_ability_categories' );
add_action( 'wp_abilities_api_init', 'wp_register_core_abilities' );
do_action( 'wp_abilities_api_init' );

global $wp_rest_server;
$wp_rest_server = null;

Expand Down
Loading