Fix: normalize line endings and style issues for document-bar #71426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #65238
This PR implements structural and maintainability improvements in the
document-barcomponent:index.jsandstyle.scss.<h1>) out of the command button to ensure valid HTML semantics..editor-document-bar.These changes improve code structure, semantics, and maintainability without changing functionality or the user experience.
Why?
The Document Bar previously had several technical and semantic issues:
By addressing these issues first, this PR prepares the component for further accessibility and UI improvements while keeping the codebase consistent and easier to maintain.
How?
.gitattributesto enforce LF line endings for JS and SCSS files.eslint --fixandstylelint --fixon thedocument-barpackage.index.js:<h1>is now outside the command<Button>.Testing Instructions
git fetch origin fix/panel-headings-63251 && git checkout fix/panel-headings-63251.npm run lint:jsandnpm run lint:cssto verify no errors appear.document-barcomponent renders correctly:document-barfiles have LF line endings usinggit diff --check.Accessibility
<h1>is now correctly placed outside the command button, improving semantics.CI / End-to-End Tests
Some Playwright E2E tests (command palette visibility, page creation) have failed in CI. These failures are likely unrelated to this PR because:
document-bar.Maintainers may choose to re-run the failing E2E tests if needed.