Skip to content

Conversation

@oliverschwendener
Copy link
Contributor

Following the example of #1242, this PR should add support for electron v33.

@oliverschwendener oliverschwendener requested review from a team and JoshuaWise as code owners October 16, 2024 15:18
Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oliverschwendener
Copy link
Contributor Author

That was fast! 😄

@m4heshd
Copy link
Contributor

m4heshd commented Oct 17, 2024

Ran the tests. Forgot to open the PR 😄. All prebuild tests passed.

@mceachen mceachen merged commit abd3546 into WiseLibs:master Oct 17, 2024
17 checks passed
@oliverschwendener oliverschwendener deleted the electron-33 branch October 17, 2024 19:54
ArGeoph pushed a commit to ArGeoph/better-sqlite3 that referenced this pull request Mar 21, 2025
feat: add support for electron 33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants