Skip to content

Conversation

@n-salim
Copy link

@n-salim n-salim commented Sep 20, 2019

…reviously skipped

@n-salim n-salim requested a review from BaoshanPang September 20, 2019 16:01
Copy link

@BaoshanPang BaoshanPang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run "sh ci/style.sh" to find the style and format problems.

@BaoshanPang
Copy link

I am seeing these errors in building rust with this branch:

error[E0412]: cannot find type passwd in crate libc
--> src/libstd/sys/vxworks/os.rs:300:31
|
300 | let mut passwd: libc::passwd = mem::zeroed();
| ^^^^^^ not found in libc

error[E0425]: cannot find function getpwuid_r in crate libc
--> src/libstd/sys/vxworks/os.rs:302:21
|
302 | match libc::getpwuid_r(libc::getuid(), &mut passwd, buf.as_mut_ptr(),
| ^^^^^^^^^^ not found in libc

@BaoshanPang
Copy link

BaoshanPang commented Sep 20, 2019

I am seeing these errors in building rust with this branch:

error[E0412]: cannot find type passwd in crate libc
--> src/libstd/sys/vxworks/os.rs:300:31
|
300 | let mut passwd: libc::passwd = mem::zeroed();
| ^^^^^^ not found in libc

error[E0425]: cannot find function getpwuid_r in crate libc
--> src/libstd/sys/vxworks/os.rs:302:21
|
302 | match libc::getpwuid_r(libc::getuid(), &mut passwd, buf.as_mut_ptr(),
| ^^^^^^^^^^ not found in libc

These functions are used in function home_dir. Do we need to support this function? It seems there is no concept of "home directory" on vxWorks.

@n-salim
Copy link
Author

n-salim commented Sep 20, 2019

These functions are used in home_dir. Do we need to support this function? It seems there is no concept of "home directory" on vxWorks.

Resolved by Wind-River/rust#24

@BaoshanPang
Copy link

Can you rebase/squash the two commits into one? This is usually what I do.

@n-salim n-salim force-pushed the master_rebase_salim branch from 8e8c899 to db1104a Compare September 20, 2019 23:01
@n-salim
Copy link
Author

n-salim commented Sep 20, 2019

Hold on, something went wrong and the style test seems to be reporting problems. Let me figure it out ...

@n-salim n-salim force-pushed the master_rebase_salim branch from db1104a to 4fed980 Compare September 20, 2019 23:14
@n-salim
Copy link
Author

n-salim commented Sep 20, 2019

OK ci/style.sh passes now. Actually it may be that I was running a newer version of rustfmt ths time.

@n-salim n-salim merged commit 78a16cb into master_rebase Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants