Skip to content

Wikilink current total for JSTOR is showing incorrect amount#464

Merged
suecarmol merged 1 commit intomasterfrom
fix-as-of-total
Aug 20, 2025
Merged

Wikilink current total for JSTOR is showing incorrect amount#464
suecarmol merged 1 commit intomasterfrom
fix-as-of-total

Conversation

@katydidnot
Copy link
Contributor

  • Fixed label formatting

Bug: T401431
Change-Id: I35ecc95d91bb01d1c670d828c8006296634d4957

Description

The "as of" date should be part of the "total" label rather than being part of the value.

Rationale

More user-friendly UI.

Phabricator Ticket

https://phabricator.wikimedia.org/T401431

How Has This Been Tested?

Smoke tested this locally.

Screenshots of your changes (if appropriate):

changed:
Screenshot 2025-08-20 at 2 58 18 PM

to:
Screenshot 2025-08-20 at 2 58 22 PM

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

- Fixed label formatting

Bug: T401431
Change-Id: I35ecc95d91bb01d1c670d828c8006296634d4957
Copy link
Contributor

@suecarmol suecarmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@suecarmol suecarmol merged commit c5cb81a into master Aug 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants