Add more composite indexes to the aggregate tables #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I pushed a commit that improves a query's performance without an index change that I found while doing some testing for this task. I can move it into another PR if this one is inappropriate for those kinds of changes. |
Contributor
Author
|
I think that test that failed is flaky since I can't reproduce that 🤔 |
These indexes help increase performance for project 'project_count' and 'editor_count'. The other slow endpoints 'top_projects' and 'top_users' may need an alternative solution. * Added an index for (organisation, username) to UserAggregate. * Added an index for (collection, username) to UserAggregate. * Added an index for (organisation, project_name) to PageProjectAggregate. * Added an index for (collection, project_name, page_name) to PageProjectAggregate. * Improved the performance of a LinkAggregate table check. Checking for the existence of LinkAggregates for a set of organisations was taking multiple seconds because a boolean check was resulting in a large query being run where an `.exists()` check could be used instead. Bug: T370533
Contributor
Author
|
This PR is ready to review now |
suecarmol
approved these changes
Mar 12, 2025
Contributor
suecarmol
left a comment
suecarmol
left a comment
There was a problem hiding this comment.
Thanks for adding the indices! I do see a performance improvement on loading the stats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These indexes help increase performance for project 'project_count' and 'editor_count'. The other slow endpoints 'top_projects' and 'top_users' may need an alternative solution such as caching with memcached which is outside the scope of this patch.
Changes
UserAggregate.UserAggregate.PageProjectAggregate.PageProjectAggregate..exists()check could be used instead.Rationale
Bad query performance has been causing issues with some queries, in-particular on the projects pages to the point where requests were timing out before they could complete. This patch adds some indexes that partially alleviates this.
Phabricator Ticket
https://phabricator.wikimedia.org/T370533
How Has This Been Tested?
Manually.
Screenshots of your changes (if appropriate):
N/A
Types of changes
What types of changes does your code introduce? Add an
xin all the boxes that apply: