Skip to content
This repository was archived by the owner on May 11, 2025. It is now read-only.

Comments

WhiskyCmd: fix the run command#1264

Open
kkHAIKE wants to merge 1 commit intoWhisky-App:mainfrom
kkHAIKE:fix
Open

WhiskyCmd: fix the run command#1264
kkHAIKE wants to merge 1 commit intoWhisky-App:mainfrom
kkHAIKE:fix

Conversation

@kkHAIKE
Copy link

@kkHAIKE kkHAIKE commented Dec 19, 2024

FIX: #1088
FIX: #1140

Fix two issues related to the run command:

  1. program.runInTerminal would launch AppleScript asynchronously via a coroutine, but the main process had already exited, preventing it from starting. Added RunLoop.main.run() to make the main process wait until the execution is completed.
  2. In program.runInTerminal, double quotes in the environment variables within wineCmd need to be escaped again.

PS: Sometimes, when the Whisky main UI runs for an extended period, it causes High CPU usage. To restore normal operation, the Whisky application itself needs to be closed (without closing the Wine-launched Windows application). The cause has not yet been identified.

@mrdc
Copy link

mrdc commented May 1, 2025

PS: Sometimes, when the Whisky main UI runs for an extended period, it causes High CPU usage. To restore normal operation, the Whisky application itself needs to be closed (without closing the Wine-launched Windows application). The cause has not yet been identified.

For me Whisky UI app high CPU usage (1 core @ 100%, sometimes 200%) starts asap I launch a process. Terminating this process brings back Whisky UI CPU usage to normal.
3

@mrdc
Copy link

mrdc commented May 8, 2025

@kkHAIKE
Related issue:
#917
and 200% usage from me:
whisky 200%

@kkHAIKE
Copy link
Author

kkHAIKE commented May 9, 2025

@mrdc try #1374

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: WhiskyCmd not launching my game [Bug]: WhiskyCmd run fails to start an app

3 participants