Skip to content

Conversation

@marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Oct 21, 2025

faf05bf

Import and fix window.orientation tests from wpt
rdar://163102280
https://bugs.webkit.org/show_bug.cgi?id=301183

Reviewed by NOBODY (OOPS!).

Imported window.orientation tests from WPT and fixed a bit.

* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/window-orientation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/window-orientation.html: Added.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/window-orientation-expected.txt: Added.

faf05bf

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

rdar://163102280
https://bugs.webkit.org/show_bug.cgi?id=301183

Reviewed by NOBODY (OOPS!).

Imported window.orientation tests from WPT and fixed a bit.

* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/window-orientation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/window-orientation.html: Added.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/window-orientation-expected.txt: Added.
@marcoscaceres marcoscaceres self-assigned this Oct 21, 2025
@marcoscaceres marcoscaceres requested a review from Copilot October 21, 2025 10:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR imports window.orientation API tests from the Web Platform Tests (WPT) repository and adds platform-specific test expectations. The tests verify the behavior of the deprecated window.orientation API and orientationchange events.

Key changes:

  • Added comprehensive test suite for window.orientation API including attribute presence, value validation, and event handling
  • Added platform-specific expected results for iOS (passing tests) and base platform (failing tests due to lack of support)

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
LayoutTests/imported/w3c/web-platform-tests/screen-orientation/window-orientation.html New test file containing 10 tests for window.orientation API behavior
LayoutTests/imported/w3c/web-platform-tests/screen-orientation/window-orientation-expected.txt Expected test results for platforms without window.orientation support (all tests fail)
LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/window-orientation-expected.txt iOS-specific expected results showing all tests pass

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 21, 2025
@aproskuryakov
Copy link
Contributor

I assume that you intend to upstream the fixes, otherwise they will get overwritten by the next reimport.

@marcoscaceres
Copy link
Contributor Author

marcoscaceres commented Oct 22, 2025

Yep, they are:
web-platform-tests/wpt#55503

(will keep them in sync or export these out otherwise)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merging-blocked Applied to prevent a change from being merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants