-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Import and fix window.orientation tests from wpt #52729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Import and fix window.orientation tests from wpt #52729
Conversation
rdar://163102280 https://bugs.webkit.org/show_bug.cgi?id=301183 Reviewed by NOBODY (OOPS!). Imported window.orientation tests from WPT and fixed a bit. * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/window-orientation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/window-orientation.html: Added. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/window-orientation-expected.txt: Added.
|
EWS run on current version of this PR (hash faf05bf)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR imports window.orientation API tests from the Web Platform Tests (WPT) repository and adds platform-specific test expectations. The tests verify the behavior of the deprecated window.orientation API and orientationchange events.
Key changes:
- Added comprehensive test suite for window.orientation API including attribute presence, value validation, and event handling
- Added platform-specific expected results for iOS (passing tests) and base platform (failing tests due to lack of support)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| LayoutTests/imported/w3c/web-platform-tests/screen-orientation/window-orientation.html | New test file containing 10 tests for window.orientation API behavior |
| LayoutTests/imported/w3c/web-platform-tests/screen-orientation/window-orientation-expected.txt | Expected test results for platforms without window.orientation support (all tests fail) |
| LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/window-orientation-expected.txt | iOS-specific expected results showing all tests pass |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
I assume that you intend to upstream the fixes, otherwise they will get overwritten by the next reimport. |
|
Yep, they are: (will keep them in sync or export these out otherwise) |
faf05bf
faf05bf