Adding Support for accept and accept4 #286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deepansharora27
force-pushed
the
accept-support
branch
from
586b8d5 to
ef32ec0
Compare
sbc100
reviewed
Apr 29, 2022
|
|
||
| int accept(int socket, struct sockaddr *restrict addr, socklen_t *restrict addrlen); | ||
| int accept4(int socket, struct sockaddr *restrict addr, socklen_t *restrict addrlen, int flags); | ||
|
|
Member
There was a problem hiding this comment.
Why do these need to be declared here, but not other socket APIs?
It looks like top-half/musl/include/sys/socket.h can be modified instead to declare these maybe?
Member
There was a problem hiding this comment.
Yes, it's admittedly confusing, and I forgot to mention it earlier, but even though wasi-libc doesn't use musl's bottom-half implementations, it does use musl's headers.
So the way to fix this is to move this #endif up two lines, to enable musl's accept declaration.
Author
There was a problem hiding this comment.
@sunfishcode So,Can I go ahead with making this change ?
Contributor
|
move to #287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a draft PR for this and have made some inital changes
Fixes #284