wasm2c: Fix periodic ASLR related crashes in sanitizer builds #2401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oh interesting. Do you think this will be permanently required fix? I wonder if you can link to some kind of upstream bug which, when resolved, would mean we could remove this? I assume this would have been an alternative way to fix binaryen in WebAssembly/binaryen#6396 |
sbc100
reviewed
Mar 18, 2024
shravanrn
force-pushed
the
w2c-sanitize-fix
branch
from
621905e to
0b52e30
Compare
Collaborator
Author
|
@sbc100 Added a link in comments |
sbc100
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix random sanitizer crashes encountered in #2400. Fix is from
actions/runner#3207 (comment)