[Linking] Remove 'Required' (0x3d) prefix from features section #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has not been emitted in LLVM since llvm/llvm-project@3f34e1b.
tlively
approved these changes
Oct 25, 2024
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
LGTM, but let's give some time to see if there are any objections.
Co-authored-by: Thomas Lively <[email protected]>
This was referenced Oct 25, 2024
Member
Author
|
Given that this has not seen any objections, will merge this and other PRs in the tools. |
aheejin
added a commit
to llvm/llvm-project
that referenced
this pull request
Nov 5, 2024
This has not been emitted since 3f34e1b. The corresponding proposed tool-conventions change: WebAssembly/tool-conventions#236
aheejin
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Nov 5, 2024
This has not been emitted in LLVM since llvm/llvm-project@3f34e1b. The corresponding proposed tool-conventions change: WebAssembly/tool-conventions#236
aheejin
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Nov 5, 2024
This has not been emitted in LLVM since llvm/llvm-project@3f34e1b. The corresponding proposed tool-conventions change: WebAssembly/tool-conventions#236
PhilippRados
pushed a commit
to PhilippRados/llvm-project
that referenced
this pull request
Nov 6, 2024
This has not been emitted since llvm@3f34e1b. The corresponding proposed tool-conventions change: WebAssembly/tool-conventions#236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has not been emitted in LLVM since
llvm/llvm-project@3f34e1b.