Rebase and clarify text #22
Conversation
|
I'll merge this patch, but happy to have further reviews. |
xtuc
left a comment
xtuc
left a comment
There was a problem hiding this comment.
Thanks for the update @littledan.
I feel like that some changes could be upstreamed directly, especially to sync with other proposals.
| </div> | ||
|
|
||
| <div algorithm> | ||
| To <dfn>instantate the core of a WebAssembly module</dfn> from a module |module| and imports |imports|, perform the following steps: |
There was a problem hiding this comment.
"instantiate the core of a WebAssembly module" is a new term? It's not part of the spec
Typo:
instantate -> instantiate
There was a problem hiding this comment.
Typo PR is #23.
What about "instantiate the internals of a WebAssembly module" instead?
| 1. [=Construct a WebAssembly module object=] from |module| and |bytes|, and return the result. | ||
| 1. [=Construct a WebAssembly module object=] from |module| and |stableBytes|, and return the result. | ||
|
|
||
| Note: Some implementations may enforce a size limitation on |bytes|. Use of this API is discouraged, in favor of asynchronous APIs. |
There was a problem hiding this comment.
While this note is correct, I hope that it will change in the future. Currently only Chrome (as far as I remember) enforce a < 4KB module.
|
|
||
| <pre class="idl"> | ||
| dictionary GlobalDescriptor { | ||
| required USVString value; |
There was a problem hiding this comment.
I think that this should be a DOMString, but it's off-topic here.
|
Sorry I forgot that you rebased, some of my comments are not relevant to this change. |
2 participants
Rebase the proposal on top of tc39/ecma262#1311, top-level await, and WebAssembly/spec#745 .
cc @linclark @xtuc @Ms2ger