-
Notifications
You must be signed in to change notification settings - Fork 831
Handle single-segment source mapping in source map header decoder #6794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kripken
merged 6 commits into
WebAssembly:main
from
osa1:single_segment_source_map_header
Aug 6, 2024
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bc6dd69
Handle single-segment source mapping in source map header decoder
osa1 3214f8a
Add a unit test
osa1 ff0e62a
Fix formatting
osa1 3445d0e
Update test
osa1 cc29a5f
Fix lint
osa1 2833da7
Update test/gtest/binary-reader.cpp
kripken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| * Copyright 2024 WebAssembly Community Group participants | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include "parser/wat-parser.h" | ||
| #include "print-test.h" | ||
| #include "wasm-binary.h" | ||
| #include "gtest/gtest.h" | ||
|
|
||
| using namespace wasm; | ||
|
|
||
| using BinaryReaderTest = PrintTest; | ||
|
|
||
| // Check that debug location parsers can handle single-segment mappings. | ||
| TEST_F(BinaryReaderTest, SourceMappingSingleSegment) { | ||
| auto moduleText = "(module)"; | ||
| Module module; | ||
| parseWast(module, moduleText); | ||
|
|
||
| BufferWithRandomAccess buffer; | ||
| WasmBinaryWriter(&module, buffer, PassOptions()); | ||
| auto moduleBytes = buffer.getAsChars(); | ||
|
|
||
| // A single-segment mapping starting at offset 0. | ||
| std::string sourceMap = R"( | ||
| { | ||
| "version": 3, | ||
| "sources": [], | ||
| "names": [], | ||
| "mappings": "A" | ||
| } | ||
| )"; | ||
| std::stringstream sourceMapStream(sourceMap); | ||
|
|
||
| // Test `readSourceMapHeader`. | ||
| { | ||
| Module module; | ||
| WasmBinaryReader binaryReader(module, FeatureSet::All, moduleBytes); | ||
| binaryReader.setDebugLocations(&sourceMapStream); | ||
| binaryReader.readSourceMapHeader(); | ||
| } | ||
|
|
||
| // Test `readNextDebugLocation`. | ||
| { | ||
| Module module; | ||
| WasmBinaryReader binaryReader(module, FeatureSet::All, moduleBytes); | ||
| binaryReader.setDebugLocations(&sourceMapStream); | ||
| binaryReader.readNextDebugLocation(); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.