fix(build with MSVC): enable bigobj support for parser
#6636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I faced the following error when building with MSVC : `\binaryen\src\parser\wat-parser.cpp(1,1): error C1128: number of sections exceeded object file format limit`. According to documentation this is related to the default allowable sections in obj files. (https://learn.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/fatal-error-c1128?view=msvc-170) On the another side of things, adding this flag might leads to slower compile time and also probbaly hides high usage of templates in source code. I added the flag only for parser.
Member
|
Another option here might be to split up |
Member
|
I can prioritize splitting up wat-parser.cpp on the 10th, when I'm back from the CG meeting. |
Contributor
Author
|
PR #6653 solves the root cause without adding a specific flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced the following error when building with MSVC :
\binaryen\src\parser\wat-parser.cpp(1,1): error C1128: number of sections exceeded object file format limit.According to documentation this is related to the default allowable sections in obj files. (https://learn.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/fatal-error-c1128?view=msvc-170)
On the another side of things, adding this flag might leads to slower compile time and also probbaly hides high usage of templates in source code.
I added the flag only for parser.