Skip to content

[table64] Preserve 64-bit table flag when writing binaries #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
May 20, 2024
Merged

[table64] Preserve 64-bit table flag when writing binaries #6610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wasm/wasm-binary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ void WasmBinaryWriter::writeImports() {
table->max,
table->hasMax(),
/*shared=*/false,
/*is64*/ false);
table->is64());
});
finishSection(start);
}
Expand Down
11 changes: 11 additions & 0 deletions test/lit/table64.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited.
;; RUN: wasm-opt %s -all --roundtrip -S -o - | filecheck %s


;; Most table64 test coverage is handled by the spec tests.
;; Here we test what the spec doesn't cover, currently just the i64 flag
;; is preserved on table imports during roundtripping.
(module
(import "env" "table" (table i64 1 funcref))
)
;; CHECK: (import "env" "table" (table $timport$0 i64 1 funcref))