Skip to content

Make array.new_fixed length annotations mandatory #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlively merged 1 commit into from
Feb 6, 2024
Merged

Make array.new_fixed length annotations mandatory #6277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/wasm/wasm-s-parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3161,18 +3161,12 @@ Expression* SExpressionWasmBuilder::makeArrayNewElem(Element& s) {

Expression* SExpressionWasmBuilder::makeArrayNewFixed(Element& s) {
auto heapType = parseHeapType(*s[1]);
size_t i = 2;
std::vector<Expression*> values;
if (i < s.size() && s[i]->isStr()) {
// With the standard syntax one should specify explicitly the size
// of the array
if ((size_t)parseIndex(*s[i]) != s.size() - 3) {
throw SParseException("wrong number of elements in array", s);
}
i++;
if ((size_t)parseIndex(*s[2]) != s.size() - 3) {
throw SParseException("wrong number of elements in array", s);
}
while (i < s.size()) {
values.push_back(parseExpression(*s[i++]));
std::vector<Expression*> values;
for (size_t i = 3; i < s.size(); ++i) {
values.push_back(parseExpression(*s[i]));
}
return Builder(wasm).makeArrayNewFixed(heapType, values);
}
Expand Down
36 changes: 0 additions & 36 deletions test/lit/array-new-fixed.wast
View file
Open in desktop

This file was deleted.