fix(observability): apply WH_LOG_LEVEL to the OTLP log exporter by taitelee · Pull Request #850 · Wave-RF/WaveHouse

taitelee · 2026-10-14T12:45:11Z

Requested by Taite · project thread

Summary

Before: WH_LOG_LEVEL reached only the stdout handler. Neither the otelslog bridge nor the log SDK filters by level, so with OTLP logs on, WH_LOG_LEVEL=WARN still built and exported every DEBUG and INFO record at otel.logs.sample_rate. The docs said the level applied to both.

After: the OTLP leg sits behind levelGate, which reads the same LevelVar as stdout and runs before the sampler. A record below the level is now neither written nor exported, and because both legs report disabled, slog skips building it at all. The WARN/ERROR 100% floor (invariant #15) still applies to every record the level admits.

How: internal/observability/logger.go adds levelGate (an slog.Handler whose Enabled checks the level, and whose WithAttrs/WithGroup keep the gate) and otlpLeg, which builds gate, then sampler, then exporter. NewLogger uses it. No wiring files changed. configuration.mdx, architecture.md, AGENTS.md and the CHANGELOG are updated to describe the behaviour.

Test plan

New tests in logger_test.go: a level table (WARN drops DEBUG/INFO, ERROR drops WARN, DEBUG admits all), the WARN floor at rate 0, runtime LevelVar changes, and the gate surviving With/WithGroup
make build, go vet ./..., go test -race ./internal/observability/ ./internal/app/
Pre-push code and docs reviewers: ship_it
GitHub CI green on 3c2d706 (lint, unit, integration, E2E, docs, coverage). This stands in for a local make ci, by the owner's decision; the local git hooks were skipped with the owner's OK.

Related Issues

Closes #397

Part of #777.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KLenXpzcNWTroqhcTf5PMX

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KLenXpzcNWTroqhcTf5PMX

…evel-jnjtdo

coderabbitai · 2026-10-14T12:45:20Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 7770eae8-71af-4540-9dd2-d528915d36e5

📥 Commits

Reviewing files that changed from the base of the PR and between 2a9fa5f and 69075f8.

📒 Files selected for processing: 6

AGENTS.md
CHANGELOG.md
docs/src/content/docs/architecture.md
docs/src/content/docs/configuration.mdx
internal/observability/logger.go
internal/observability/logger_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details

🧰 Additional context used

📚 Code guidelines: 3

AGENTS.md — auto-discovered
.github/copilot-instructions.md — auto-discovered
CONTRIBUTING.md — auto-discovered

📓 Path-based instructions: 4

Source excerpt: Create `*_test.go` files in the same package as the code under test.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

internal/observability/logger_test.go

See [AGENTS.md](../AGENTS.md) for project conventions, architecture notes, and AI agent instructions.

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Files:

AGENTS.md

Applicability reference: AGENTS.md: # AGENTS.md — AI Agent Instructions for WaveHouse **Scope** is the canonical docs-prose set from `scripts/docs-prose.sh` — a *denylist*: every tracked `.md`/`.mdx` EXCEPT `.claude/**`, `.github/**`, `CHAN...

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Files:

docs/src/content/docs/configuration.mdx

Source excerpt: **In MDX, leave a blank line between a JSX tag and a code fence.**

📄 CodeRabbit inference engine (AGENTS.md)

Files:

docs/src/content/docs/configuration.mdx

🧠 Learnings: 1

📓 Common learnings

Learnt from: CR
Repo: Wave-RF/WaveHouse

Timestamp: 2026-10-14T15:43:00.442Z
Learning: Source excerpt:
# AGENTS.md — AI Agent Instructions for WaveHouse

## Operating Rules

3. **Every code change updates its docs + `CHANGELOG.md` in the same PR** — a code change without its doc update is incomplete ([§Documentation Sync](#documentation-sync)).

🪛 LanguageTool

CHANGELOG.md

[typographical] ~33-~33: Consider using an em dash in dialogues and enumerations.
Context: - **WH_LOG_LEVEL now filters the OTLP l...

(DASH_RULE)

docs/src/content/docs/architecture.md

[style] ~198-~198: Consider shortening this phrase to just ‘whether’, unless you mean ‘regardless of whether’.
Context: ...ogger in it too, so stdout carries them whether or not OTLP logs are on. otlpSamplerFn is ex...

(WHETHER)

🔇 Additional comments: 6

internal/observability/logger.go: 1

62-93: LGTM!

Also applies to: 96-99, 117-117

internal/observability/logger_test.go: 1

200-234: LGTM!

Also applies to: 236-250, 252-266, 268-279

AGENTS.md: 1

44-44: LGTM!

CHANGELOG.md: 1

33-33: LGTM!

docs/src/content/docs/architecture.md: 1

198-198: LGTM!

docs/src/content/docs/configuration.mdx: 1

301-301: LGTM!

Also applies to: 334-334

📝 Summary

Summary by CodeRabbit

Bug Fixes
- WH_LOG_LEVEL now filters records for both stdout and OTLP logging. Records below the configured level are not written to either output.
- OTLP sampling continues to apply to admitted DEBUG and INFO records, while WARN and ERROR records remain exported at 100%.
Documentation
- Updated logging and configuration guidance to clarify how the log level and OTLP sampling affect each output.

The OTLP log path now applies the shared WH_LOG_LEVEL threshold before sampling and export. Tests cover threshold changes, derived handlers, and sampling behavior. Documentation and the changelog describe the updated filtering rules.

Changes: OTLP log level filtering

Layer / File(s)	Summary
Gate, export, and validate OTLP logs `internal/observability/logger.go`, `internal/observability/logger_test.go`, `AGENTS.md`, `CHANGELOG.md`, `docs/src/content/docs/architecture.md`, `docs/src/content/docs/configuration.mdx`	The OTLP leg checks the shared level before sampling and export. Tests cover configured and changing thresholds, derived handlers, and zero sampling. Documentation describes which records pass the level gate and sampling rules.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Medium

Sequence Diagram(s)

sequenceDiagram
  participant Logger
  participant levelGate
  participant sampler
  participant OTLPExporter
  Logger->>levelGate: Send log record
  levelGate->>sampler: Forward record when level meets threshold
  sampler->>OTLPExporter: Forward record according to sampling rules

Suggested reviewers: ericandrechek

Merge Risk: ⚪ Minimal · up to 69075

This change makes WH_LOG_LEVEL filter OTLP log export as well as stdout, which matches the documentation. No actionable merge-blocking risk was found.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 62.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. (4 skipped: 4…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Linked Issues check		Issue `#397` requires `WH_LOG_LEVEL` to filter the OTLP leg, avoid sub-level export and record construction, and preserve the WARN/ERROR 100% sampling floor. `levelGate` reads the shared `slog.LevelVar`…
Out of Scope Changes check		The changed logger code directly implements issue `#397`. The logger tests verify the new level gate and the existing sampling floor. The configuration, architecture, AGENTS.md, and CHANGELOG updates do…
Title check		The title clearly and concisely identifies the main change: applying WH_LOG_LEVEL to the OTLP log exporter.
Description check		The description directly explains the OTLP level gate, sampling behavior, implementation, documentation updates, and test coverage.

Full details: Docstring Coverage

Explanation

Docstring coverage is 62.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. (4 skipped: 4 unsupported.)

Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

✨ Simplify code

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-14T12:48:04Z

📚 Docs preview

✅ Live: https://pr-850-wavehouse-docs.wave-rf.workers.dev (follows this PR)
This commit (69075f8): https://eb5555de-wavehouse-docs.wave-rf.workers.dev (exactly this commit; open it if the link above looks stale)

Commit: 69075f8 Merge remote-tracking branch 'origin/main' into claude/397-otlp-log-level-jnjtdo
Author: @taitelee
Committed: 2026-10-14 10:39 EDT
Uploaded: 2026-10-14 11:52 EDT (run)

Earlier commits (1)

Commit	Preview (that commit only)	Uploaded
`3c2d706`	https://f00e3aa1-wavehouse-docs.wave-rf.workers.dev	2026-10-14 08:48 EDT

github-code-quality · 2026-10-14T12:49:15Z

Code coverage overview

Languages: Go

Go

main 2a9fa5f	claude/397-otlp-log-... 69075f8	+/-
93%	93%	0%

View coverage of the 3 most impacted files.

File	main 2a9fa5f	claude/397-otlp-log-... 69075f8	+/-
`internal/mq/embedded.go`	90%	90%	0%
`internal/observ...ility/logger.go`	100%	100%	0%
`internal/mq/external.go`	85%	86%	+1%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

_{Updated October 14, 2026 15:53 UTC}

…evel-jnjtdo

taitelee · 2026-10-14T14:57:46Z

@coderabbitai review

coderabbitai · 2026-10-14T14:57:57Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

taitelee · 2026-10-14T15:42:11Z

@coderabbitai review

coderabbitai · 2026-10-14T15:42:20Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

taitelee and others added 2 commits October 14, 2026 12:41

fix(observability): apply WH_LOG_LEVEL to the OTLP log exporter

7fa001d

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KLenXpzcNWTroqhcTf5PMX

Merge remote-tracking branch 'origin/main' into claude/397-otlp-log-l…

3c2d706

…evel-jnjtdo

github-project-automation Bot added this to WaveHouse Task Board Oct 14, 2026

github-project-automation Bot moved this to Backlog in WaveHouse Task Board Oct 14, 2026

taitelee self-assigned this Oct 14, 2026

github-actions Bot added documentation Improvements or additions to documentation go Pull requests that update go code area/observability Metrics, logs, traces, health, profiling area/docs Documentation, site/, README labels Oct 14, 2026

Merge remote-tracking branch 'origin/main' into claude/397-otlp-log-l…

69075f8

…evel-jnjtdo

coderabbitai Bot approved these changes Oct 14, 2026

View reviewed changes

taitelee marked this pull request as ready for review October 14, 2026 15:49

taitelee requested review from a team and EricAndrechek October 14, 2026 15:49

taitelee merged commit 1671de6 into main Oct 14, 2026

taitelee deleted the claude/397-otlp-log-level-jnjtdo branch October 14, 2026 15:53

github-project-automation Bot moved this from Backlog to Done in WaveHouse Task Board Oct 14, 2026

Navigation Menu

Repository navigation

fix(observability): apply WH_LOG_LEVEL to the OTLP log exporter - #850

fix(observability): apply WH_LOG_LEVEL to the OTLP log exporter#850
taitelee merged 3 commits into
mainfrom
claude/397-otlp-log-level-jnjtdo

taitelee commented Oct 14, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 14, 2026 •

edited

Loading

Summary by CodeRabbit

Sequence Diagram(s)

Uh oh!

github-actions Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

github-code-quality Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

taitelee commented Oct 14, 2026

Uh oh!

coderabbitai Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

taitelee commented Oct 14, 2026

Uh oh!

coderabbitai Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

taitelee commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Related Issues

Uh oh!

coderabbitai Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Sequence Diagram(s)

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📚 Docs preview

Uh oh!

github-code-quality Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code coverage overview

Go

Uh oh!

taitelee commented Oct 14, 2026

Uh oh!

coderabbitai Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taitelee commented Oct 14, 2026

Uh oh!

coderabbitai Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

taitelee commented Oct 14, 2026 •

edited

Loading

coderabbitai Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-code-quality Bot commented Oct 14, 2026 •

edited

Loading

coderabbitai Bot commented Oct 14, 2026 •

edited

Loading

coderabbitai Bot commented Oct 14, 2026 •

edited

Loading