[taitelee]

Summary

time_range.since/until accept relative durations and sdk.md advertises day suffixes (7d), but Go's time.ParseDuration stops at hours — so "7d" failed to parse and fell through to ClickHouse as a raw DateTime literal, surfacing as an opaque Cannot read DateTime error (a retryable 500, per #271). This fixes it in the structured-query builder:

• Day/week suffixes work. resolveTimeValue pre-expands Nd→N*24h and Nw→N*168h (7d→168h, 2w→336h, 1d12h→24h12h) before time.ParseDuration, so the documented ranges resolve correctly.
• Invalid input fails closed. resolveTimeValue now returns an error for any value that is neither a relative duration nor an RFC3339 timestamp, and Build maps it to a 400 with a clear message instead of handing a raw string to ClickHouse.

Test plan

• Added TestExpandDayWeek, TestResolveTimeValue_DayWeekSuffix, TestResolveTimeValue_Invalid, and a Build-level invalid time range since duration case; updated the three existing resolveTimeValue tests for the new (string, error) signature
• Manual sanity: POST /v1/query with time_range.since: "7d" returns rows; "banana" returns 400

Related Issues

Closes #285
Relates to #271 (opaque ClickHouse error → 400)

[coderabbitai]

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Free

Run ID: 8ea1d3dc-33c7-413f-bae6-91bdc4761077

📥 Commits

Reviewing files that changed from the base of the PR and between 099c654 and 365232d.

📒 Files selected for processing (1)

• internal/query/ast.go

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes

  • Time range parameters now accept day/week relative durations (e.g., 7d, 2w) and return clear HTTP 400 errors for invalid/unparseable values.

• Documentation

  • API and SDK docs updated to indicate RFC3339 timestamps and expanded relative-duration formats are accepted.

• Tests

  • Added coverage for duration suffixes, day/week expansion, bucketing behavior, and proper error handling for invalid time inputs.

Walkthrough

This PR adds day/week duration suffixes to time range parameters, making since/until accept formats like 7d and 2w alongside RFC3339 timestamps. Parsing now fails fast with descriptive errors (resulting in HTTP 400) instead of deferring invalid values to ClickHouse.

Changes

Time Range Parsing Enhancement

Layer / File(s)	Summary
Core time parsing implementation internal/query/builder.go	Introduces expandDayWeek to convert d/w suffixes to hours, and restructures resolveTimeValue to return (string, error), rejecting any value that is neither a valid expanded duration nor a valid RFC3339Nano timestamp.
Time parsing tests internal/query/builder_test.go	New tests for expandDayWeek suffix conversion, resolveTimeValue d/w resolution, multi-unit and fractional forms, and invalid input rejection. Existing tests updated to assert resolveTimeValue error returns before checking output.
Query builder integration and validation internal/query/builder.go, internal/query/builder_test.go	buildWhere now calls resolveTimeValue with error propagation for timeRange.since, and TestBuild_InvalidColumns validates the build fails with "invalid time value" when since is unparseable.
Documentation and changelog CHANGELOG.md, docs/src/content/docs/api.md, docs/src/content/docs/sdk.md, internal/query/ast.go	Adds Unreleased "Fixed" entry documenting day/week suffix support and closed-fail error handling. API and SDK docs updated to list 7d/2w as supported relative formats and mention 400 errors for unparseable time_range values. Minor inline comment formatting updated in TimeRange.Since.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

📚 Docs preview is live: https://12e06032-wavehouse-docs.wave-rf.workers.dev

Updated for commit 365232d