Skip to content

Upstream 09.03-15.03#349

Merged
DVOniksWyvern merged 63 commits intoWWhiteDreamProject:masterfrom
Spatison:upstream
Mar 15, 2025
Merged

Upstream 09.03-15.03#349
DVOniksWyvern merged 63 commits intoWWhiteDreamProject:masterfrom
Spatison:upstream

Conversation

@Spatison
Copy link
Copy Markdown
Member

@Spatison Spatison commented Mar 15, 2025

Изменения

🆑

  • add: Upstream 09.03-15.03

EctoplasmIsGood and others added 30 commits March 15, 2025 13:25
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Makes a lot of disabilities give more points (based off community and
personal opinions), and makes some very strong traits cost more points.

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- tweak: Narcolepsy gives 6 points instead of 2
- tweak: Pacifist gives 8 points instead of 6
- tweak: Muted gives 6 points instead of 4
- tweak: Sluggish gives 5 points instead of 3
- tweak: Snail Paced gives 8 points instead of 5
- tweak: Blood Deficiency gives 6 points instead of 5
- tweak: Hemophilia gives 4 points instead of 2
- tweak: Clumsy gives 4 points instead of 1
- tweak: Bad knees gives 5 points instead of 3
- tweak: Will to live costs 3 points instead of 1
- tweak: Tenacity costs 4 points instead of 3
- tweak: Steadfast costs 6 points instead of 4
- tweak: Bionic Arm costs 10 points instead of 8
- tweak: Bionic leg costs 8 points instead of 6

---------

Signed-off-by: EctoplasmIsGood <109397347+EctoplasmIsGood@users.noreply.github.com>

(cherry picked from commit d38eb0b536a34475feefa8253b9a3ed128e57f4d)
(cherry picked from commit 8a2626ef6b62508a6479525555522b516e090feb)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Description.

Fix bug affecting torches, flares and glowsticks that made them not emit
light when turned on as described by [this
issue.](Simple-Station/Einstein-Engines#1685)

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

https://github.com/user-attachments/assets/799631e0-bcf1-4008-9683-3d0ba7c02a24

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- fix: Torches, flares, glowsticks now able to emit light again

(cherry picked from commit b25e3447148948ee658d1b81dac0d1e076641fcc)
(cherry picked from commit 83fbb13c3aab8fedb1e56f73b949ac1a458eee41)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

<p>
Adds the mining dock & mining shuttle console for travel to lavaland.
Adds NTR office with the NTR locker mapped. Also adds the BSO locker to
bridge without an office cause BSO is not worthy.
Map render under images. NTR office is south east of brig. Just has a
desk and a bed. No fax as the NTR already has their own fax, I feel like
having a second fax would increase where the NTR would need to look for
faxes.
Referring to the shuttle that takes one to lavaland as mining shuttle,
not the pathfinder.
</p>

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

![Arena](https://github.com/user-attachments/assets/a9719209-becd-4315-8b57-e0179b8eb8d7)

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
no cl no fun

(cherry picked from commit e481e2f182f162b78e22524dfe6988b2135bd32f)
(cherry picked from commit f59bd7df32f6942f3b2646c1e3a08ee88343301d)
# Description

Porting - Allow Construction of Fireplaces and Bonfires

Ported from - Goob-Station/Goob-Station#1646

Yeah it's a port of a port. Yes there was sofas, benches and banners,
I've very lazily stolen just the fires. Sofa might be nice but that's
lot more code pinching.

---

# TODO

- [ ] Pray it works

---

# Changelog

:cl:
- add: Recipes to build Fireplaces and Bonfires

---------

Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
(cherry picked from commit 90485d5a0c49f76950d61e42c3cc596f988dc982)
(cherry picked from commit c7327f55f8576267f30a384d4a84fd85f357d52f)
# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Added a new weapon, the DT-8 "Terminus"
It's a large melee weapon capable of firing a spread of disabler rounds
on alternate fire.
It's an arsenal tech research, and uniquely can only be wielded by onis.

(I'm being bribed to make this)
Also, I had to move the OniComponent.cs file to shared. I'm not sure if
that borked anything but tell me if it does.

(PS. Thank you VMSolidus for helping me make this ten times less
shitcoded.)

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Textures complete
- [x] Add lathe recipe
- [x] Add to research

---

<details><summary><h1>Media</h1></summary>
<p>

!![image](https://github.com/user-attachments/assets/cf02d64a-53a8-4454-9312-010fa92cf597)

</p>
</details>

---

# Changelog

:cl: SolsticeOfTheWinter, OtherPersonPlaceHolder
- add: Added a new weapon for oni security players, the terminus.

---------

Signed-off-by: Solstice <solsticeofthewinter@gmail.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>

(cherry picked from commit 3fdf1102dc20af7bd724e449808d2d38571e62c2)
(cherry picked from commit 9de8ab79e61227620833b88f5c616c63f38c9a86)
# Summary

To add the RPD into the game for both atmos and CE's to use. Introduce
pipe stacking as well since the RPD will introduce better atmos
configuration. Most of the code was ported over from goob LRP. With some
of it being touched up on and adding a bit of quality of life to the
RPD.

This was a PR originally made for goob-mrp but requested to be moved to
EE. Check out the detailed commits here:
Goob-Station/Goob-Station-MRP#96

---

# Description

## RPD
From the original PR made on goob-station the RPD has been ported over.
It is similar to the RCD where you will be able to make
pipes/vents/pumps/mixers quickly. Each dial on the main radial will
bring up specific pipes like ie pipes-> corner, t-shape -cross shape.

The RPD starts out in the CE and Atmos lockers with 50 charges. Each
construction and deconstruction cost 1 charge. There is also one extra
compressed matter in the starting lockers for both CE and Atmos for the
RPD.

You can research the recipe of the RPD with the reverse engineering
machine. The recipe cost of the RPD is a bit more compared to the RCD.

![RPD_UI](https://github.com/user-attachments/assets/ed2fe76b-009a-4081-abe4-7c431f21ab27)

## Pipe Stacking

With the introduction of the RPD, it was fair to check for pipes that
overlapped when making new pipes. But with introducing the code from LRP
goob station it was decided to bring over the pipe stacking feature too.
You can make certain components pipe stackable or allow if you can put
multiple of the same pipe on the same tile. If you want you change a
pipe to be non-stackable by using the component type:
PipeRestrictOverlap

Here's an example of pipe stacking. You can make a simple scrub loob
tighter or keep it normal. The freedom is given.
![pipe-stacking
example](https://github.com/user-attachments/assets/69aa19d4-2ff4-4cee-a2d1-b6709884c6e0)

Here is an extreme example. This compact design creates a ton of frezon.
Obviously, replace the trit miner with an actual burn chamber.

![image](https://github.com/user-attachments/assets/4db7b627-0d3a-4c78-b5a1-8d52551b3127)

## Belt overlay

I decided to add a simple belt overlay sprite to the game for the RPD.

Here's what it looks like outside the belt and inside the belt

![RPD](https://github.com/user-attachments/assets/d599dbed-56d0-42c7-acee-20fa23f04f2c)

## RPD Borg Module

I decided to add experimental RPD that will self-charge. The only way to
get this RPD is through admeme spawn or being a borg. The starting
charge of the Borg module is 25 and will self-charge at the same rate at
10 seconds per charge. I also added an admeme version that charges at 1
second per charge.

Here is what the borg module looks like
![Borg
module](https://github.com/user-attachments/assets/6fd1bcff-fdb7-49ad-a8f5-e4bab86bd8f4)

The borg module can be researched in the t2 industrial branch as the
same research for the RCD module.

![Research-rpd](https://github.com/user-attachments/assets/d325dd3f-eed9-4744-9003-3b7d51387432)

---

# credit
Original RPD PR: Goob-Station/Goob-Station#1203
Original Pipe Stacking PRs:
Goob-Station/Goob-Station#391
Goob-Station/Goob-Station#389
Prevent stacking pipes (#28308) - Original Link is dead.

---

# TODO
- [X] Add RPD
- [X] Add RPD to reverse engineering
- [x] Add toolbelt equipped sprites
- [x] Add Pipe Stacking
- [x] Add an experimental RPD module for engie borgs.

---

# Changelog

:cl:
- add: Added RPD, glory to atmosia!
- tweak: RPD now spawns in Atmos and CE lockers
- tweak: Extra compressed matter has been added into both Atmos/CE
lockers for more RPD/RCD uses
- add: You can research RPD with the reverse engineering machine.
- add: A belt overlay sprite to the CE and utility toolbelt.
- add: Pipe Stacking ported over from LRP Goob station. Compress those
frezon factories!
- add: Toolbelt overlay sprite for the RPD.
- add: RPD Borg module researched in t-2 industrial advanced tools.

---------

Co-authored-by: Nathaniel Adams <60526456+Nathaniel-Adams@users.noreply.github.com>

(cherry picked from commit b32710c94628f90e4b2c43796ac3ab81892926f3)
(cherry picked from commit 3270ee0327054fd0187cb03756d23a1a84d7916c)
# Description
Ports Stun Meta from
[/Goob-Station#788](Goob-Station/Goob-Station#788)
Splits stuncrit into knockdown and paralysis, like on 13. knockdown lets
you crawl on the floor, and paralysis is the same as current stamcrit.
The stun baton has been buffed, doing 15 stamina damage per swing, and
40 stamina damage overtime.
This lets you stamcrit someone in two baton swings, but it takes a few
seconds before they actually fall down to the ground. About the same
amount of time as 4 baton swings back to back.

This PR also reverts WWhiteDreamProject#809, since I plan on reworking shoving entirely
soon.
(also for my sanity. wouldn't have been able to port stunmeta
otherwise.)

## Condemn Trillions
Required for the rest of the SS13 Combat Parity changes listed
[here](https://discord.com/channels/1218698320155906090/1348171706061033502)

# TODO
* [x] Await merge
* [x] Gaming

# Media

![shitcurity](https://github.com/user-attachments/assets/4f83937f-7eaa-4d6d-a446-4044f9ec0286)

# Changelog
🆑 Eagle

* tweak: Stamina Crit has been split into Knockdown and Paralysis
* tweak: Stun batons now do 15 stamina damage on hit, and 40 over time

(cherry picked from commit b8045750e91b8e43fcf91deaeb49b295a0984cdc)
(cherry picked from commit cbadf45b9e1bbb8cbb122a579e9c37a3234d506b)
# Description

Ports the following PRs:
WWhiteDreamProject#271
WWhiteDreamProject#282
WWhiteDreamProject#255
WWhiteDreamProject#254
WWhiteDreamProject#246
WWhiteDreamProject#223
WWhiteDreamProject#220
WWhiteDreamProject#219
WWhiteDreamProject#213

This is a rather huge variety of fixes to be honest.

# Changelog

:cl: White Dream
- fix: Fixed airlock opening and closing visuals
- fix: Fixed Weather spamming infinite sounds.
- fix: Cockroaches no longer spam organs when stepped on.
- fix: Fixed the timer on the Return To Round button
- fix: Fixed Return to Round not remembering how long it's been since
you died if you re-enter your body.
- fix: Fixed harpy flight visuals not showing for other people.
- fix: Fixed disabler bolts not going through windows like other kinds
of lasers.
- fix: Fixed Vim Harness being free
- fix: Fixed handcuffs not respecting your arm length.
- fix: Made tending wounds not as message spammy.
- fix: Fixed shuttle windows not preventing you from being electrocuted
by grills under them.

---------

Co-authored-by: vanx <61917534+Vaaankas@users.noreply.github.com>
Co-authored-by: vanx <discord@vanxxxx>
Co-authored-by: Spatison <137375981+Spatison@users.noreply.github.com>
Co-authored-by: Repo <47093363+Titian3@users.noreply.github.com>

(cherry picked from commit ced8a565a32cfa340140674c073d90a2a6002799)
(cherry picked from commit 89f27f4b2f3882ba97132d69f9d6477cea3195d1)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Fixed bug that made ClothingAddFactionComponent not add the faction of
the clothing to the mob when the clothing is equipped.

The bug is described in greater detail in [this
issue](Simple-Station/Einstein-Engines#1228).

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

https://github.com/user-attachments/assets/41fe9411-0eac-478d-956c-b094f211f565

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- fix: Fixed bug that made ClothingAddFactionComponent not work.

(cherry picked from commit 639f46a68b84ad6d0655ec318ccc62fa3061c5cd)
(cherry picked from commit b4c488af30ad9e21e41b409282aeac1f8ae37c9e)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Stolen from Floof-Station/Floof-Station#152, courtesy
of cynical24. When you craft a curtain or make a table into a _fancy_
table, it doesn't take the entire stack of carpet. This should hopefully
stop me from having to return to the HoP to ask for another 10 carpet.

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] general thievery of text (with permission)

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

![curtains](https://github.com/user-attachments/assets/0c960653-311a-40e7-bcbe-53e50d771c63)

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- tweak: you don't use the entire stack of carpet now when crafting
colored curtains or fancy tables.

(cherry picked from commit 508dbc35d3576be768122604d39194ee715ab02a)
(cherry picked from commit f4641de5073d3cf1ccc54a5599281bb6025149fc)
what the funny title says

<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Adds some markings from Impstation (Again, who would have thought it'd
be Impstation again?), ports the merciful IPC wings from Goob LRP, adds
some markings to arachnids, a bunch of markings for Reptilians, and a
new hairstyle.

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [ ] Task
- [x] Completed Task

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl: Diggy
- add: New markings for arachnids, reptilians.
- tweak: Allows IPCs to pick up overlay markings such as the gauze
stuff, Onis can now have the curved horn marking humans can have.

(cherry picked from commit b955652cf18f1a11e7d48206f32c8d3e24e819bd)
(cherry picked from commit 78149f74ac386a81b4ecb46679db29c9e5f1946e)
# Description

Vulpkanin no longer wear their undergarments "Superman Style"

# Changelog

:cl:
- fix: After lengthy retraining, NanoTrasen has taught Vulpkanin that
underwear is meant to be worn inside pants, not outside them.

(cherry picked from commit 190dddf7c59537ffc2781f3d8f7bcb16e5a449fb)
(cherry picked from commit a7138473115dfe767b822eb2b24179a04f6133e5)
# Description

It had basically always bothered me, and evidently a lot of other people
that turrets were previously "Unfair enemies". They had perfect aimbot
accuracy, tracked targets instantly at any angle, and were
nigh-indestructible. It was telling that players were pretty much only
ever killed by turrets once or twice, and then they figure out that the
turrets are outright impossible to beat in a fair fight, so they end up
resorting to underhanded tactics like using an RCD to wall the turret
off. Or use a pickaxe to go around them.

I previously added a new turret for the SAN dropship, and with it had
tried out a very different approach for "Fairer Turret" balancing. A
more reasonable healthbar, no instant tracking, and no perfect accuracy,
The players enjoyed these a lot more than the original turrets. Plus
they were more visually interesting firing an inaccurate spray at their
targets.

<details><summary><h1>Media</h1></summary>
<p>

I'm on my lunch break at college right now, so no media.

</p>
</details>

# Changelog

:cl:
- tweak: Adjusted turrets to be a more "Fair" fight. They no longer have
perfect aimbot accuracy, they don't track targets instantly, and they
also have a "More fair" healthbar that can reasonably be shot through by
someone with good enough weapons and armor,

(cherry picked from commit 6bdd73efe210d6e556e6accbc89cb9134f716e2e)
(cherry picked from commit bedcd65d4d8324a651101a978ba90d46d4199cfa)
Just a random event that had a tiny chance to spawn an Abstract entity.

(cherry picked from commit f49712f82569d7e5f0a486d00130216dc73520bd)
# Description

@Errant-4 by request in your comment.
I had annihilated this before during the NyanoCombat reworks, but during
a recent wizmerge most of said reworks were accidentally reverted. This
is the one that was brought back, comment and all. So this PR fixes for
a second time a problem left by the old combat system.

# Changelog

:cl:
- fix: Power attack and light attack damages are no longer swapped.

Signed-off-by: VMSolidus <evilexecutive@gmail.com>

(cherry picked from commit 4b988b2b01e379d5a2c6c8eae72f70c00876d024)
(cherry picked from commit 505765017a164ca20582571f92f5ec95ff3e5579)
# Description

Somehow I didn't realize that .45 magnum, despite being a common ammo
type available to a lot of people, deals literally double the damage of
all other comparable smallarms. No wonder people were complaining about
the Universals being comically overpowered. This PR normalizes their
damage so that it's still "More than other equivalent small arms
calibers", but not ".45 is more than double the damage of 9mm".

# Changelog

:cl:
- tweak: Nerfed universals and other .45 auto guns. I get the meme that
.45 is better than 9mm, but not "More than double" the damage of 9mm.

(cherry picked from commit f7f49f67d69e6a19a3b83eec1d4cb4b0b7ca93a1)
SimpleStation14 and others added 15 commits March 15, 2025 14:22
(cherry picked from commit 12876a1ce113a68a79d2cae79e99a6748446c13e)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Add a two second cooldown on the Revolutionary Manifesto's secondary use
(the purely cosmetic one) to not make it cause chat spam.
I made this change from web and have NOT tested it yet (unless I checked
the checkbox below in the TODO section!

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [ ] TEST IF IT WORKS

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- tweak: Tweaked rev manifesto to not spam chat anymore

(cherry picked from commit 3a6634125445a3a71ab33dae090942ce3216d340)
(cherry picked from commit 0ba6aae78f5ee3804f8eaf30afc2e35bafc8e17c)
# Description

I can't believe we never cleaned these up. Yea so our codebase made an
astoundingly fucking poor first impression on BPL during their huge
playtest, and most of these CVars were to blame. In particular is the
godawful Ramping Event Scheduler having "Murder the station with
ventcritters every 10 seconds at the 30 minute mark" as its settings.

# Changelog

:cl:
- tweak: Disabled Monstermos Tile Ripping by default.
- tweak: Default settings for Ramping Event Scheduler no longer throws
"Ventcritters every 10 seconds, 30 minutes into the round".

(cherry picked from commit ef5dc3441aa3b7c62d771039c3e1a93ba04a0d32)
(cherry picked from commit 0fce50daf5ba999e3bc9b8c97e8e7b8791fb7f7e)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]? -->

A downstream port of TheDenSS14/TheDen#306
providing Blue and Red paintjobs for the Blueshield and Head of Security
BRDIs respectively.

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name This includes
all available types for the changelog -->

:cl:
- tweak: Gave the BSO and HoS BRDIs a fancy paintjob.

(cherry picked from commit 4f23e0d40549fc3780d1dd94f7fea2ff83e37c24)
(cherry picked from commit 2d7e39eca59cee8c8c883501c8f185bcb8bff4cb)
Truly the PR of all time...

<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

The markings by themselves have localization or whatev. When you color
them they will however appear as marking_etc_etc.
Yes, i'm aware it's lazy, but i'm not doing it for over 80 markings,
just not feeling it, this is really just a test to see if it gets
allowed without some locale files setup.

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [ ] Task
- [x] Completed Task

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl: Diggy
- add: Most markings from ADT, along with two new hairstyles, new
markings for Shadowkin (Despite all my hate for them).
- fix: Shadowkin ears are now colorable again, fuck around and find out
if you want your Shadowkin's ears to be pink with red or something.

(cherry picked from commit a36b5dc2404578c64a93a9881714f00180c1da02)
(cherry picked from commit cd81f90db975061f9d968b45beab9a461834f4c1)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Changes Box to Cyberiad, with the service area receiving a rework, in
the future there will be more updates in the depts, with the next one
probably being the Sec.
Make some fixes on Gax and Bagel.

I changed the maintainer of some maps from "Estação Pirata" to "Ichai".
I am not part of the Estação Pirata

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

![image](https://github.com/user-attachments/assets/e18d2441-8c01-49b9-9c6a-9d2c2c4672b6)

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl: Ichai
- add: Cyberiad added to the rotation.
- fix: Gax: Fixed missing window in CE office, Fixed walls in SM to
prevent radiation leaks.
- tweak: Port changes to Bagel from GoobStation
- remove: Box is no more.

---------

Signed-off-by: VMSolidus <evilexecutive@gmail.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>

(cherry picked from commit 3da2771a5509b189b4599a2323e9df5d7b9fb562)
(cherry picked from commit 755fc9912d4152dca446477ea2693ed91aac59c1)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Added back slot and suit storage sprites for the R-25 BRDI.

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- add: Added back worn sprites for the R-25 BRDI.

(cherry picked from commit 2cf4957ccd3ed2e0a673c7a7c774f4d779428cb5)
(cherry picked from commit d6ba9f7c0da450e0b8ae6623b33e6933360ae43c)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

I don't know why this was being done, but it didn't seem to do anything
and I know for a fact it was causing issues with shaders that were
applied on all humanoid layers, so... "Imaginary Technique: Shitcode
Removal" go.

If anything breaks, it's this.

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [X] Check that the game didn't incinerate itself.

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

![image](https://github.com/user-attachments/assets/ff7f41e5-827e-4fdf-98e2-b5885aadf467)

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

no cl

Signed-off-by: Eris <eris@erisws.com>

(cherry picked from commit e674f782e24da7a7825520ca650473f155e9e4c1)
@github-actions
Copy link
Copy Markdown
Contributor

RSI Diff Bot; head commit eb7cf25 merging into 5ed9158
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Belt/belt_overlay.rsi

State Old New Status
rpd Added

Resources/Textures/Mobs/Aliens/Lavaland/magma_hand.rsi

State Old New Status
magma_hand Added

Resources/Textures/Objects/Specific/Robotics/borgmodule.rsi

State Old New Status
icon-rpd Added

Resources/Textures/Objects/Tools/rpd.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Weapons/Melee/terminus.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added
wielded-inhand-left Added
wielded-inhand-right Added

Resources/Textures/_ADT/Mobs/Customization/Demon/custom.rsi

State Old New Status
cow_ears Added
cow_horns Added
cow_spots Added
deer_antlers_horns Added
demon_ears Added
demon_tail Added
ears_elf Added
guards_stripes Added
horns_buffalo Added
horns_capricorn Added
horns_devil Added
horns_devil2 Added
horns_devil3 Added
horns_devil4 Added
horns_ram Added
horns_unicorn Added
lines_emperos Added
long Added
queen_lines Added
small_horns Added
tree_lines Added
trinity_spots Added
up Added

Resources/Textures/_ADT/Mobs/Customization/Hair/hair.rsi

State Old New Status
honor Added
shaved_female Added

Resources/Textures/_ADT/Mobs/Customization/Human/custom.rsi

State Old New Status
tattoo_KrenelMercenary Added
tattoo_Rose Added
tattoo_arm_imheartmom_l Added
tattoo_arm_imheartmom_r Added
tattoo_churchdomes Added
tattoo_elysium_patriotism Added
tattoo_fullskelet Added
tattoo_karabel Added
tattoo_line_arm_l Added
tattoo_line_arm_r Added
tattoo_narsi Added
tattoo_serpenttemptation Added
tattoo_skelet_arm_l Added
tattoo_skelet_arm_r Added
tattoo_skelet_body Added
tattoo_skelet_foot_l Added
tattoo_skelet_foot_r Added
tattoo_skelet_leg_l Added
tattoo_skelet_leg_r Added
tattoo_skull Added
tattoo_skull_face Added
tattoo_symbol_elysium Added
tattooarm-laza_l Added
tattooarm-laza_r Added

Resources/Textures/_ADT/Mobs/Customization/Reptilian/custom.rsi

State Old New Status
drawing_khar Added
drawing_skelet_body Added
drawing_skeleton Added
drawing_sun Added
drawing_warpaint Added
horns_baran Added
horns_bullhorns Added
horns_crown Added
horns_five Added
horns_highback Added
horns_jacksonchameleon Added
horns_long Added
horns_stagbeetle Added
horns_superlong Added
horns_twoago Added
lineeyes Added
tatto_skelet_arm_l Added
tatto_skelet_arm_r Added
tatto_skelet_leg_l Added
tatto_skelet_leg_r Added

Resources/Textures/_ADT/Mobs/Customization/Reptilian/reptilian_ears.rsi

State Old New Status
avali_inner Added
avali_outer Added
chemlight_inner Added
chemlight_outer Added
dragonlong Added
easternd_ears Added
easternd_horns Added
magus_ears Added
magus_neck Added
sylveon_primary Added
sylveon_secondary Added
sylveon_tertiary Added

Resources/Textures/_ADT/Mobs/Customization/Reptilian/reptilian_snouts.rsi

State Old New Status
easterndnw_primary Added
easterndnw_secondary Added
easterndw_primary Added

Resources/Textures/_ADT/Mobs/Customization/Reptilian/reptilian_tails.rsi

State Old New Status
axolotl Added
datashark_ears Added
datashark_ears_inner Added
datashark_fin Added
datashark_tail Added
datashark_taildata Added
easternd_primary Added
easternd_secondary Added
fish_primary Added
fish_secondary Added
maw Added
shark_fin Added
shark_tail Added
snake Added

Resources/Textures/_ADT/Mobs/Customization/Shadekin/shadekin_ears_32x32.rsi

State Old New Status
aqua_default Added
aqua_incolor Added
bull_default Added
bull_smooth Added
cowling_secondary Added

@Spatison Spatison self-assigned this Mar 15, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 15, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

57 files out of 168 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@DVOniksWyvern DVOniksWyvern merged commit a3a8c19 into WWhiteDreamProject:master Mar 15, 2025
13 of 14 checks passed
@Spatison Spatison deleted the upstream branch March 15, 2025 15:30
Spatison pushed a commit to Spatison/swdpublic that referenced this pull request Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.