Closed
Conversation
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sidvishnoi
reviewed
Jan 15, 2025
Collaborator
There was a problem hiding this comment.
Given Firefox & Safari don't support Permissions-Policy, but they both support iframe allow attribute, maybe this file should add some more focus on that attribute.
Also, extension doesn't support the header as of now. But it has partial support for allow attribute (interledger/web-monetization-extension#575).
Collaborator
raducristianpopa
left a comment
raducristianpopa
left a comment
There was a problem hiding this comment.
iii) APIs & Headers review:
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Sid Vishnoi <[email protected]>
Co-authored-by: Sid Vishnoi <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
melissahenderson
approved these changes
Jan 22, 2025
This reverts commit 9f10a82.
Collaborator
|
Replacing this PR with #498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the replacement PR for #463 after the main branch visual update