Skip to content

Fix/cs builder context leak #4903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JohnLangford wants to merge 5 commits into from
Closed

Fix/cs builder context leak #4903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a88721
fix: free builder_context in DeleteBuilder to prevent memory leak
JohnLangford Mar 2, 2026
f602ce1
fix: add null checks in flatbuffer namespace field accessors
JohnLangford Mar 2, 2026
54e3e55
fix: close ns_extent on error paths in flatbuffer parse_namespaces
JohnLangford Mar 2, 2026
723e042
style: apply clang-format to pylibvw.cc
JohnLangford Mar 2, 2026
80bfa85
fix: free workspace_context and prevent GC of IO adapters in C# bindings
JohnLangford Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cs/vw.net.native/vw.net.builders.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ API void DeleteBuilder(vw_net_native::builder_context* builder)
ex.is_newline = false;
}
}

delete builder;
}

API void BuilderPreallocate(vw_net_native::builder_context* builder, vw_net_native::dotnet_size_t size)
Expand Down
1 change: 1 addition & 0 deletions cs/vw.net.native/vw.net.workspace.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ API vw_net_native::ERROR_CODE DeleteWorkspace(
try
{
VW::finish(*workspace->vw);
delete workspace;
return VW::experimental::error_code::success;
}
CATCH_RETURN_STATUS
Expand Down
2 changes: 2 additions & 0 deletions cs/vw.net/VowpalWabbitBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ private unsafe static New<VowpalWabbitBase> BindConstructorArguments(VowpalWabbi
IOReaderAdapter modelReader = new IOReaderAdapter(settings.ModelStream);

IntPtr result = NativeMethods.CreateWorkspaceWithModelData(new IntPtr(argumentsPtr), argumentsSize, modelReader.GetVTable(), traceListener, localTraceContext, localStatus.ToNativeHandleOrNullptrDangerous());
GC.KeepAlive(modelReader);

if (result == IntPtr.Zero || localStatus.ErrorCode != NativeMethods.SuccessStatus)
{
Expand Down Expand Up @@ -423,6 +424,7 @@ public void SaveModel(Stream stream)
IOWriterAdapter writer = new IOWriterAdapter(stream);
NativeMethods.WorkspaceSavePredictorToWriter(this.DangerousGetHandle(), writer.GetVTable(), status.ToNativeHandleOrNullptrDangerous());
GC.KeepAlive(this);
GC.KeepAlive(writer);

if (status.ErrorCode != NativeMethods.SuccessStatus)
{
Expand Down
Loading
Loading