feat: Adds new ccb metrics for comparing first slot label with the us… #3365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er specified baseline
slahabar
commented
Oct 6, 2021
jackgerrits
reviewed
Oct 6, 2021
jackgerrits
reviewed
Oct 6, 2021
olgavrou
approved these changes
Oct 6, 2021
lalo
reviewed
Oct 7, 2021
| all->example_parser->metrics->DsjsonSumCostOriginalFirstSlot += interaction.originalLabelCostFirstSlot; | ||
|
|
||
| std::vector<std::string> enabled_reductions; | ||
| if (all->l != nullptr) { all->l->get_enabled_reductions(enabled_reductions); } |
Collaborator
There was a problem hiding this comment.
this will be a severe perf hit
Collaborator
There was a problem hiding this comment.
this should not be on the parser, on metrics.cc it gets executed once, here it gets executed per line, asking recursively to the parser to generate the stack names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er specified baseline