fix: remove v_array copy from --onethread and std::function from parse_dispatch #3301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
changed the title
olgavrou
reviewed
Sep 8, 2021
|
|
||
| private: | ||
| v_array<example*> _examples; | ||
| const v_array<example*>* _examples; |
Collaborator
There was a problem hiding this comment.
why was this made a pointer? who owns the _examples memory?
Member
Author
There was a problem hiding this comment.
A v_array is passed in it needs to be converted to this interface to be processed. In the past this relied on the shallow copy of the v_array to function efficiently. _examples is owned by whoever calls parse_dispatch and we are done with it by the end of the call
olgavrou
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.