feat: add clamp function to math library and migrate usages #3299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalo
reviewed
Sep 13, 2021
vowpalwabbit/active.cc
Outdated
| if (ld.label != FLT_MAX && !ec.test_only) | ||
| { all.sd->weighted_labels += (static_cast<double>(ld.label)) * static_cast<double>(ec.weight); } | ||
| all.sd->weighted_unlabeled_examples += ld.label == FLT_MAX ? static_cast<double>(ec.weight) : 0.0; | ||
| // all.sd->weighted_unlabeled_examples += ld.label == FLT_MAX ? static_cast<double>(ec.weight) : 0.0; |
Collaborator
There was a problem hiding this comment.
whats the deal with this comment?
Member
Author
There was a problem hiding this comment.
Oh great catch thank you! This line is redundant because of line 114 and i was going to open a PR to remove it. However, I accidentally added it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.