Skip to content

fix: add back setting active property in reduction setup #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackgerrits merged 4 commits into from
Sep 3, 2021
Merged

fix: add back setting active property in reduction setup #3290

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4687bb
fix: add back setting active property in reduction setup
jackgerrits Sep 3, 2021
2920f53
Update active.cc
jackgerrits Sep 3, 2021
5b7f865
Update active.cc
jackgerrits Sep 3, 2021
02506da
Merge branch 'master' into jackgerrits-patch-5
jackgerrits Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vowpalwabbit/active.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ base_learner* active_setup(VW::setup_base_i& stack_builder)
learn_returns_prediction = base->learn_returns_prediction;
}

all.active = true;

// Create new learner
auto reduction_builder = make_reduction_learner(std::move(data), base, learn_func, pred_func, reduction_name);
reduction_builder.set_label_type(label_type_t::simple);
Expand Down