refactor: use override for loss function virtual functions #3280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
approved these changes
Sep 2, 2021
lalo
added a commit
to lalo/vowpal_wabbit
that referenced
this pull request
Sep 2, 2021
commit d80b02f Author: Eduardo Salinas <[email protected]> Date: Thu Sep 2 17:06:08 2021 +0000 mac ci commit 21cde41 Author: Eduardo Salinas <[email protected]> Date: Thu Sep 2 16:43:47 2021 +0000 more include shenanigans commit 7a7f7ca Author: Eduardo Salinas <[email protected]> Date: Thu Sep 2 16:00:36 2021 +0000 shuffle includes commit 1bf0c1c Merge: 7aae740 26aad37 Author: Jack Gerrits <[email protected]> Date: Thu Sep 2 11:09:16 2021 -0400 Merge branch 'master' into fix_ut commit 26aad37 Author: Jack Gerrits <[email protected]> Date: Thu Sep 2 11:08:21 2021 -0400 refactor: use override for loss function virtual functions (VowpalWabbit#3280) * refactor: use override for loss function virtual functions * formatting commit 7aae740 Author: Eduardo Salinas <[email protected]> Date: Thu Sep 2 14:50:15 2021 +0000 test: unit tests improvements 1) remove print from explore_test.cc 2) shift things around from tutorial_test.cc to simulator.h 3) add callback hook to simulator
lalo
added a commit
to lalo/vowpal_wabbit
that referenced
this pull request
Sep 2, 2021
commit d80b02f Author: Eduardo Salinas <[email protected]> Date: Thu Sep 2 17:06:08 2021 +0000 mac ci commit 21cde41 Author: Eduardo Salinas <[email protected]> Date: Thu Sep 2 16:43:47 2021 +0000 more include shenanigans commit 7a7f7ca Author: Eduardo Salinas <[email protected]> Date: Thu Sep 2 16:00:36 2021 +0000 shuffle includes commit 1bf0c1c Merge: 7aae740 26aad37 Author: Jack Gerrits <[email protected]> Date: Thu Sep 2 11:09:16 2021 -0400 Merge branch 'master' into fix_ut commit 26aad37 Author: Jack Gerrits <[email protected]> Date: Thu Sep 2 11:08:21 2021 -0400 refactor: use override for loss function virtual functions (VowpalWabbit#3280) * refactor: use override for loss function virtual functions * formatting commit 7aae740 Author: Eduardo Salinas <[email protected]> Date: Thu Sep 2 14:50:15 2021 +0000 test: unit tests improvements 1) remove print from explore_test.cc 2) shift things around from tutorial_test.cc to simulator.h 3) add callback hook to simulator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.