fix: resolve more gcc warnings #3271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
reviewed
Sep 1, 2021
| }; | ||
|
|
||
| inline bool example_is_test(polylabel& l) { return l.cs.costs.size() == 0; } | ||
| inline bool example_is_test(polylabel* l) { return l->cs.costs.size() == 0; } |
Collaborator
There was a problem hiding this comment.
just curious what was the warning here?
Member
Author
There was a problem hiding this comment.
The warning originated where we were reinterpret casting this from from polylabel& to polylabel*
This line:
this->priv->all->example_parser->lbl_parser.test_label = reinterpret_cast<bool (*)(polylabel*)>(is_test);So this was a flow on from that
olgavrou
approved these changes
Sep 1, 2021
lalo
pushed a commit
to lalo/vowpal_wabbit
that referenced
this pull request
Sep 2, 2021
* fix: resolve more gcc warnings * For some reason vector resize was not initializing the added values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.