refactor: migrate active to builder and fix warnings #3243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
changed the title
bassmang
reviewed
Aug 26, 2021
| reduction_builder.set_learn_returns_prediction(learn_returns_prediction); | ||
| if (!simulation) { reduction_builder.set_finish_example(return_active_example); } | ||
|
|
||
| return make_base(*reduction_builder.build()); |
Member
There was a problem hiding this comment.
Could stick to the usual style with something like:
auto* finish_ptr = simulation ? reinterpret_cast<void (*)(vw&, active&, example&)>(return_simple_example) : return_active_example
Then chaining the .sets with .set_finish_example(finish_ptr)
Member
Author
There was a problem hiding this comment.
Conditionally setting this allows the default to change without having to update this code. It's a little uglier but I'd prefer to not leak the return_simple_example implementation detail
vowpalwabbit/active.cc
Outdated
| std::sqrt((1.f + 0.5f * std::log(k)) / (weighted_queries + 0.0001f)); | ||
| bias = get_active_coin_bias(k, avg_loss, ec_revert_weight / k, a.active_c0); | ||
| } | ||
| if (a._random_state->get_and_update_random() < bias) |
Member
There was a problem hiding this comment.
Could add this change as well:
return (a._random_state->get_and_update_random() < bias) ? 1.f / bias : -1.f;
bassmang
approved these changes
Aug 31, 2021
This was referenced Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.