feat: add cache helper for reading and writing types directly #3057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokitoth
reviewed
Jun 9, 2021
| if (buf_read(c, sizeof(T)) < sizeof(T)) | ||
| { | ||
| if (debug_name != nullptr) | ||
| { THROW("Failed to read cache value: " << debug_name << ", with size: " << sizeof(T)); } |
Member
There was a problem hiding this comment.
This is probably out of scope for this change, but does it make sense to have a mode where an error in reading from the cache would cause the learning to switch back to reading from non-cache? Or is the coordination hard enough to make it not worth the time?
Member
Author
There was a problem hiding this comment.
In the current landscape the coordination to achieve that is hard enough to not make it worth it. I can see it being a nice thing to have in future though.
olgavrou
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.