feat: add several functions to namespaced_features #3040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
reviewed
Jun 8, 2021
vowpalwabbit/namespaced_features.cc
Outdated
| indices_copy.erase(last, indices_copy.end()); | ||
| return indices_copy; | ||
| auto it = _hash_to_index_mapping.find(hash); | ||
| #ifndef VW_NOEXCEPT |
Collaborator
There was a problem hiding this comment.
if this is used with noexcept it will fail miserably, maybe add:
#else
if (it == end())
return {};
and return an empty set
…errits/vowpal_wabbit into namespaced_features_update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
clearget_indicesa constant time operationget_index_for_hashRename:
indextons_indexin some places to clarify it is the 1 byte namespace index and not asize_tcollection index