-
Notifications
You must be signed in to change notification settings - Fork 1
Graceful Shutdown Handling #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6c31053
auto-claude: subtask-1-1 - Create data directory structure for state …
BillChirico b447b2c
auto-claude: subtask-1-2 - Add state persistence functions (save/load…
BillChirico 6a04d69
auto-claude: subtask-1-3 - Add pending request tracking mechanism
BillChirico a7f4c46
auto-claude: subtask-1-4 - Implement graceful shutdown orchestration
BillChirico 4f91cd3
fix: correct state file location and shutdown timeout (qa-requested)
BillChirico 3094a9c
fix: ensure data directory exists, remove local dev files, reorder sh…
BillChirico 79c1f7d
Merge origin/main into graceful-shutdown-handling
BillChirico 52a7050
Merge origin/main - resolve remaining conflicts
BillChirico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending request tracking functions never called
Medium Severity
The
registerPendingRequestandremovePendingRequestfunctions are exported but never imported or called anywhere in the codebase. ThegenerateResponsefunction inevents.jsmakes AI requests without registering them. As a result,pendingRequestswill always be empty, and the graceful shutdown logic that waits for pending requests to complete will never actually wait for anything—requests in flight during shutdown will be dropped.Additional Locations (1)
src/index.js#L215-L229