feat(ai): add blocked channel check to triage module (#180) by BillChirico · Pull Request #225 · VolvoxLLC/volvox-bot

BillChirico · 2026-03-02T13:53:22Z

Summary

Completes #180 - Configurable AI channel blocklist

What was done

The feature was already partially implemented. Added the missing check in triage.js:

Import isChannelBlocked from ai.js
Add blocked channel check in accumulateMessage function to skip blocked channels
Add isChannelBlocked mock to triage tests

Already implemented (existing)

Config schema has blockedChannelIds
isChannelBlocked function exists in ai.js
events.js uses it to block AI responses
Dashboard has the UI for selecting blocked channels
Config validation and allowlist

Testing

Files pass lint
Implementation complete

- Import isChannelBlocked from ai.js - Add blocked channel check in accumulateMessage to skip blocked channels - Add isChannelBlocked mock to triage tests The blocked channel feature is now fully implemented: - Config schema has blockedChannelIds - isChannelBlocked function exists in ai.js - events.js uses it to block AI responses - triage.js now also checks for blocked channels - Dashboard has the UI for selecting blocked channels

coderabbitai · 2026-03-02T13:53:31Z

Warning

Rate limit exceeded

@BillChirico has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 53 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1b28c80 and 499fe77.

📒 Files selected for processing (2)

src/modules/triage.js
tests/modules/triage.test.js

📝 Walkthrough

Walkthrough

The pull request introduces channel blocking functionality to the triage module with corresponding test coverage, reorganizes imports in the config module, and applies minor formatting adjustments to command and module files.

Changes

Cohort / File(s)	Summary
Code Style Updates `src/commands/rolemenu.js`, `src/modules/roleMenuTemplates.js`	Minor formatting adjustments including multi-line assignment restructuring and conditional return statements with no semantic changes.
Module Import Cleanup `src/modules/config.js`	Removed duplicate DANGEROUS_KEYS import; now imported once from ../api/utils/dangerousKeys.js.
Channel Blocking Feature `src/modules/triage.js`	Added isChannelBlocked import and implemented channel blocking logic in accumulateMessage that skips processing for blocked channels based on computed parentId context.
Test Coverage `tests/modules/triage-budget.test.js`, `tests/modules/triage.test.js`	Added mock isChannelBlocked function (defaulting to false) and new test cases covering early-return blocking behavior, parentId handling for threads, and non-thread channel scenarios.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and clearly summarizes the main change: adding a blocked channel check to the triage module as part of completing issue `#180`.
Description check	✅ Passed	The description is directly related to the changeset, explaining what was implemented in triage.js and the context of the broader feature completion.
Docstring Coverage	✅ Passed	Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/issue-180-ai-blocklist

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Adds the missing triage-side enforcement of the AI blocked-channel list so the bot fully ignores messages in blocked channels (per #180).

Changes:

Import and apply isChannelBlocked inside triage.accumulateMessage() to skip triage processing for blocked channels.
Update triage tests to mock isChannelBlocked.
Minor formatting-only adjustments in role menu/template and config modules.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/modules/triage.js`	Adds blocked-channel gating to triage message accumulation.
`tests/modules/triage.test.js`	Extends AI module mock to include `isChannelBlocked`.
`src/modules/roleMenuTemplates.js`	Formatting-only change to an `if` statement.
`src/modules/config.js`	Import order/whitespace cleanup.
`src/commands/rolemenu.js`	Formatting-only changes (line wrapping / arrow param parens).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/modules/triage.js

tests/modules/triage.test.js

greptile-apps · 2026-03-02T13:59:04Z

Greptile Summary

This PR completes the AI channel blocklist feature by adding blocked channel checks to the triage module. The implementation correctly handles the distinction between threads and regular channels when checking parentId, and includes a safety check in evaluateNow to prevent processing buffered messages if a channel is blocked after buffering.

Added isChannelBlocked check in accumulateMessage to skip blocked channels early
Added blocked channel check in evaluateNow to handle race conditions where channels become blocked after message buffering
Properly distinguishes between threads (where parentId is the parent channel) and regular channels in categories (where parentId is the category ID)
Comprehensive test coverage including edge cases for thread vs category channel handling
Minor unrelated formatting changes (linting fixes) in rolemenu, config, and roleMenuTemplates files

Confidence Score: 5/5

This PR is safe to merge with no identified issues
The implementation is well-tested with comprehensive edge case coverage, properly handles the thread/category distinction that was flagged in the previous review, includes defensive error handling in evaluateNow, and follows existing patterns from events.js. The formatting changes are benign linting fixes.
No files require special attention

Important Files Changed

Filename	Overview
src/modules/triage.js	Added blocked channel checks in `accumulateMessage` and `evaluateNow` with proper thread/category handling
tests/modules/triage.test.js	Comprehensive tests for blocked channel logic including thread vs category channel handling

_{Last reviewed commit: 499fe77}

greptile-apps

_{5 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

src/modules/triage.js

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/modules/triage.js`:
- Around line 638-641: The current blocklist check only prevents new
accumulation but lets evaluateNow act on already-buffered content; update the
evaluation path (the evaluateNow function) to re-check
isChannelBlocked(channelId, parentId, guildId) before any classification or
response, and if blocked immediately abort processing and remove/clear the
buffered messages for that channel from the pending buffer (e.g., messageBuffers
/ whatever buffer/map holds pending messages) so previously buffered content
cannot be evaluated later.

In `@tests/modules/triage.test.js`:
- Around line 336-388: Add a regression test that verifies a channel can be
buffered by accumulateMessage and later blocked before evaluateNow so no
classifier/responder runs; specifically, in tests/modules/triage.test.js create
a new it block that calls accumulateMessage(...) for a message (using
makeMessage and accumulateMessage), then mock isChannelBlocked to return true
when evaluateNow runs, call await evaluateNow(channelId, config, client,
healthMonitor), and assert that addToHistory was not called and
mockClassifierSend/mockResponder (or whatever classifier/responder spies are
used in this file) were not called; reference existing helper names
accumulateMessage, evaluateNow, isChannelBlocked, addToHistory, and
mockClassifierSend to locate where to add and what to assert.

ℹ️ Review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d04016 and 1b28c80.

📒 Files selected for processing (6)

src/commands/rolemenu.js
src/modules/config.js
src/modules/roleMenuTemplates.js
src/modules/triage.js
tests/modules/triage-budget.test.js
tests/modules/triage.test.js

📜 Review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Greptile Review

🧰 Additional context used

📓 Path-based instructions (5)

**/*.js