feat: outbound webhook notifications for important bot events (#130)

biome.json

@@ -8,7 +8,8 @@
       "!node_modules",
       "!coverage",
       "!logs",
-      "!data"
+      "!data",
+      "!feat-issue-164"
     ]
   },
   "linter": {

migrations/005_webhook_notifications.cjs

@@ -0,0 +1,42 @@
+/* eslint-disable */
+'use strict';
+
+/**
+ * Migration 005: Webhook notifications delivery log
+ *
+ * Creates webhook_delivery_log table to store delivery attempts
+ * per webhook endpoint. Endpoint configs live in the per-guild config JSON.
+ */
+
+/** @param {import('node-pg-migrate').MigrationBuilder} pgm */
+exports.up = (pgm) => {
+  pgm.sql(`
+    CREATE TABLE IF NOT EXISTS webhook_delivery_log (
+      id SERIAL PRIMARY KEY,
+      guild_id TEXT NOT NULL,
+      endpoint_id TEXT NOT NULL,
+      event_type TEXT NOT NULL,
+      payload JSONB NOT NULL,
+      status TEXT NOT NULL CHECK (status IN ('success', 'failed', 'pending')),
+      response_code INTEGER,
+      response_body TEXT,
+      attempt INTEGER NOT NULL DEFAULT 1,
+      delivered_at TIMESTAMPTZ DEFAULT NOW()
+    );
+
+    CREATE INDEX IF NOT EXISTS idx_webhook_delivery_log_guild
+      ON webhook_delivery_log (guild_id, delivered_at DESC);
+
+    CREATE INDEX IF NOT EXISTS idx_webhook_delivery_log_endpoint
+      ON webhook_delivery_log (endpoint_id, delivered_at DESC);
+  `);
+};
+
+/** @param {import('node-pg-migrate').MigrationBuilder} pgm */
+exports.down = (pgm) => {
+  pgm.sql(`
+    DROP INDEX IF EXISTS idx_webhook_delivery_log_endpoint;
+    DROP INDEX IF EXISTS idx_webhook_delivery_log_guild;
+    DROP TABLE IF EXISTS webhook_delivery_log;
+  `);
+};

src/api/index.js

@@ -16,6 +16,7 @@ import guildsRouter from './routes/guilds.js';
 import healthRouter from './routes/health.js';
 import membersRouter from './routes/members.js';
 import moderationRouter from './routes/moderation.js';
+import notificationsRouter from './routes/notifications.js';
 import ticketsRouter from './routes/tickets.js';
 import webhooksRouter from './routes/webhooks.js';
 
@@ -58,6 +59,9 @@ router.use('/moderation', requireAuth(), auditLogMiddleware(), moderationRouter)
 // GET-only; no audit middleware needed (reads are not mutating actions)
 router.use('/guilds', requireAuth(), auditLogRouter);
 
+// Notification webhook management routes — require API secret or OAuth2 JWT
+router.use('/guilds', requireAuth(), auditLogMiddleware(), notificationsRouter);
+
 // Webhook routes — require API secret or OAuth2 JWT (endpoint further restricts to api-secret)
 router.use('/webhooks', requireAuth(), webhooksRouter);
 

src/api/routes/ai-feedback.js

@@ -92,6 +92,11 @@ router.get(
   async (req, res, next) => {
     try {
       const guildId = req.params.id;
+      const pool = req.app.locals.dbPool;
+
+      if (!pool) {
+        return res.status(503).json({ error: 'Database unavailable' });
+      }
 
       let days = 30;
       if (req.query.days !== undefined) {
@@ -101,9 +106,10 @@ router.get(
         }
       }
 
+      // Let errors bubble up to the outer catch block
       const [stats, trend] = await Promise.all([
-        getFeedbackStats(guildId),
-        getFeedbackTrend(guildId, days),
+        getFeedbackStats(guildId, pool),
+        getFeedbackTrend(guildId, days, pool),
       ]);
 
       res.json({
@@ -188,6 +194,11 @@ router.get(
   async (req, res, next) => {
     try {
       const guildId = req.params.id;
+      const pool = req.app.locals.dbPool;
+
+      if (!pool) {
+        return res.status(503).json({ error: 'Database unavailable' });
+      }
 
       let limit = 25;
       if (req.query.limit !== undefined) {
@@ -197,7 +208,19 @@ router.get(
         }
       }
 
-      const feedback = await getRecentFeedback(guildId, limit);
+      // Let errors bubble up to the outer catch block
+      const rawFeedback = await getRecentFeedback(guildId, limit, pool);
+
+      // Normalize DB row keys to camelCase (handles both raw SQL and aliased results)
+      const feedback = rawFeedback.map((row) => ({
+        id: row.id,
+        messageId: row.messageId ?? row.message_id,
+        channelId: row.channelId ?? row.channel_id,
+        userId: row.userId ?? row.user_id,
+        feedbackType: row.feedbackType ?? row.feedback_type,
+        createdAt: row.createdAt ?? row.created_at,
+      }));
+
       res.json({ feedback });
     } catch (err) {
       next(err);