feat: Reaction role menus (#162)

[BillChirico]

Summary

Implements #162 — Reaction Role Menus.

Allows server admins to create messages where members can self-assign roles by reacting with specific emojis. Roles are revoked when reactions are removed. All mappings persist in PostgreSQL across bot restarts.

Changes

Migration

• migrations/004_reaction_roles.cjs — Creates reaction_role_menus and reaction_role_entries tables

New module: src/modules/reactionRoles.js

• DB helpers: insertReactionRoleMenu, findMenuByMessageId, listMenusForGuild, deleteMenu, upsertReactionRoleEntry, removeReactionRoleEntry, getEntriesForMenu, findRoleForReaction
• buildReactionRoleEmbed — Discord blurple embed with emoji→role list
• handleReactionRoleAdd / handleReactionRoleRemove — grant/revoke role on reaction event
• resolveEmojiString — stable string key for both Unicode and custom emojis

New command: src/commands/reactionrole.js

• /reactionrole create [title] [channel?] [description?] — Post a new menu
• /reactionrole add [message_id] [emoji] [role] — Map emoji → role
• /reactionrole remove [message_id] [emoji] — Remove a mapping
• /reactionrole delete [message_id] — Delete menu + Discord message
• /reactionrole list — List all menus in the server
• Requires Manage Roles permission; guards against role hierarchy violations

Events: src/modules/events.js

• Hooks handleReactionRoleAdd/Remove into the existing registerReactionHandlers before the starboard early-return guard

Tests

• 40 tests across tests/modules/reactionRoles.test.js and tests/commands/reactionrole.test.js
• Covers all DB helpers, emoji resolution, embed builder, event handlers (grant/skip/revoke), and all command subcommands

Closes #162

[coderabbitai]

Warning

Rate limit exceeded

@BillChirico has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 19 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 2791afb and d0894b3.

📒 Files selected for processing (7)

• migrations/004_reaction_roles.cjs
• node_modules
• src/commands/reactionrole.js
• src/modules/events.js
• src/modules/reactionRoles.js
• tests/commands/reactionrole.test.js
• tests/modules/reactionRoles.test.js

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/issue-162

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Implements “reaction role menus” so guild admins can post a menu message and let members self-assign / self-revoke roles via reaction add/remove events, with mappings persisted in Postgres.

Changes:

• Adds Postgres schema for reaction-role menus + emoji→role entries.
• Introduces src/modules/reactionRoles.js for DB helpers, embed building, and reaction add/remove role handlers.
• Adds /reactionrole slash command to create/manage menus and wires handlers into the global reaction event pipeline.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
migrations/004_reaction_roles.cjs	Creates reaction_role_menus / reaction_role_entries tables and indexes for persistence.
src/modules/reactionRoles.js	DB accessors, embed builder, and add/remove event handlers for granting/revoking roles.
src/commands/reactionrole.js	Adds /reactionrole command with create/add/remove/delete/list + embed refresh logic.
src/modules/events.js	Calls reaction-role handlers before starboard early-return logic.
tests/modules/reactionRoles.test.js	Unit tests for DB helpers, emoji resolution, embed builder, and reaction handlers.
tests/commands/reactionrole.test.js	Unit tests for /reactionrole subcommands and error paths.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[greptile-apps]

Greptile Summary

Implements self-service reaction role menus where members assign/remove roles by reacting to messages with specific emojis. All mappings persist in PostgreSQL across restarts.

Architecture:

• Migration creates reaction_role_menus and reaction_role_entries tables with proper indexes and CASCADE delete
• reactionRoles.js module provides DB helpers, event handlers (handleReactionRoleAdd/Remove), and embed builder
• /reactionrole command with 5 subcommands (create/add/remove/delete/list) for admin management
• Integrated into existing reaction event flow in events.js before starboard checks
• 40 tests across both module and command test files

Key features:

• Role hierarchy validation prevents bot from assigning roles above its own
• Guild ownership checks prevent cross-server manipulation
• Supports both Unicode and custom emojis via resolveEmojiString
• Proper permission gates (Manage Roles required)

Issues found:

• handleReactionRoleAdd and handleReactionRoleRemove have getPool() calls outside their try-catch blocks with unreachable null checks, since getPool() throws instead of returning null (see inline comments)

Confidence Score: 3/5

• Safe to merge after fixing the getPool() error handling issues in event handlers
• Two logic errors in event handlers where getPool() is called outside try-catch blocks with unreachable null checks. The errors won't cause crashes (caught by outer try-catch in events.js) but produce misleading error logs. Tests mock getPool() to return null, creating test/production mismatch. Otherwise solid: comprehensive tests, proper permission checks, follows project patterns, no security issues.
• Fix getPool() placement in src/modules/reactionRoles.js lines 181-183 and 233-235

Important Files Changed

Filename	Overview
migrations/004_reaction_roles.cjs	Creates database schema for reaction role menus and entries with proper indexes and CASCADE delete
src/modules/reactionRoles.js	Core reaction role logic with DB helpers, event handlers, and embed builder; has getPool() error handling issue where null check won't work since getPool() throws instead of returning null
src/commands/reactionrole.js	Slash command with 5 subcommands (create/add/remove/delete/list) for managing reaction role menus; includes role hierarchy validation
src/modules/events.js	Integrates reaction role handlers into existing reaction event flow with proper try-catch wrappers before starboard early-return

Sequence Diagram

sequenceDiagram
    participant User
    participant Discord
    participant Bot
    participant DB as PostgreSQL
    
    Note over User,DB: Setup: Admin creates reaction role menu
    User->>Bot: /reactionrole create [title]
    Bot->>Discord: Post embed with title
    Discord-->>Bot: Message created (message_id)
    Bot->>DB: INSERT reaction_role_menus
    Bot-->>User: Menu created! Use /reactionrole add
    
    User->>Bot: /reactionrole add [message_id] [emoji] [role]
    Bot->>DB: SELECT menu by message_id
    DB-->>Bot: Menu found
    Bot->>DB: UPSERT reaction_role_entry
    Bot->>Discord: Add bot reaction to message
    Bot->>Discord: Update embed with emoji→role mapping
    Bot-->>User: Mapping added
    
    Note over User,DB: Runtime: Member reacts to get role
    User->>Discord: Reacts with emoji
    Discord->>Bot: messageReactionAdd event
    Bot->>DB: SELECT role_id for (message_id, emoji)
    DB-->>Bot: role_id found
    Bot->>Discord: members.fetch(user_id)
    Discord-->>Bot: Member object
    Bot->>Discord: member.roles.add(role_id)
    Discord-->>User: Role granted
    
    Note over User,DB: Runtime: Member un-reacts to remove role
    User->>Discord: Removes reaction
    Discord->>Bot: messageReactionRemove event
    Bot->>DB: SELECT role_id for (message_id, emoji)
    DB-->>Bot: role_id found
    Bot->>Discord: member.roles.remove(role_id)
    Discord-->>User: Role revoked

Loading

_{Last reviewed commit: d0894b3}

[greptile-apps]

_{7 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

getPool() throws instead of returning null (see src/db.js:314-318), so the null check on line 183 is unreachable and the try-catch won't catch the error from getPool().

Move getPool() inside the try-catch:

Suggested change

	*/
	export async function handleReactionRoleAdd(reaction, user) {
	const pool = getPool();
	export async function handleReactionRoleAdd(reaction, user) {
	try {
	const pool = getPool();

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/modules/reactionRoles.js
Line: 181-183

Comment:
`getPool()` throws instead of returning null (see `src/db.js:314-318`), so the null check on line 183 is unreachable and the try-catch won't catch the error from `getPool()`.

Move `getPool()` inside the try-catch:

```suggestion
export async function handleReactionRoleAdd(reaction, user) {
  try {
    const pool = getPool();
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

Same issue as handleReactionRoleAdd — getPool() throws instead of returning null, making the null check unreachable.

Suggested change

	const pool = getPool();
	if (!pool) return;
	export async function handleReactionRoleRemove(reaction, user) {
	try {
	const pool = getPool();

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/modules/reactionRoles.js
Line: 233-235

Comment:
Same issue as `handleReactionRoleAdd` — `getPool()` throws instead of returning null, making the null check unreachable.

```suggestion
export async function handleReactionRoleRemove(reaction, user) {
  try {
    const pool = getPool();
```

How can I resolve this? If you propose a fix, please make it concise.