-
Notifications
You must be signed in to change notification settings - Fork 2
feat: AI response feedback via 👍👎 reactions (#182) #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9c82b28
feat: AI response feedback via 👍👎 reactions (#182)
BillChirico da5f513
fix(events): handle MessageReactionRemove to delete AI feedback row
BillChirico 2ff8af7
fix(migrations): fix ai_feedback column constraints and add composite…
BillChirico dc5f508
fix(aiFeedback): replace internal pool pattern with shared getPool fr…
BillChirico 9a33992
fix(api): join conversations table in /recent to include AI response …
BillChirico dd0f2a9
docs(readme): document ai.feedback.enabled config key
BillChirico 49af040
refactor(web): move FeedbackStats to shared web/src/types/api.ts
BillChirico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /** | ||
| * Migration 003: AI Response Feedback Table | ||
| * | ||
| * Stores 👍/👎 reactions from users on AI-generated messages. | ||
| * Per-user per-message deduplication via UNIQUE constraint. | ||
| * Gated behind ai.feedback.enabled in config (opt-in per guild). | ||
| */ | ||
|
|
||
| /** @param {import('node-pg-migrate').MigrationBuilder} pgm */ | ||
| exports.up = (pgm) => { | ||
| pgm.sql(` | ||
| CREATE TABLE IF NOT EXISTS ai_feedback ( | ||
| id SERIAL PRIMARY KEY, | ||
| message_id TEXT NOT NULL, | ||
| channel_id TEXT NOT NULL, | ||
| guild_id TEXT NOT NULL, | ||
| user_id TEXT NOT NULL, | ||
| feedback_type TEXT CHECK (feedback_type IN ('positive', 'negative')), | ||
BillChirico marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| created_at TIMESTAMP DEFAULT NOW(), | ||
BillChirico marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
BillChirico marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| UNIQUE(message_id, user_id) | ||
| ) | ||
| `); | ||
|
|
||
| pgm.sql(` | ||
| CREATE INDEX IF NOT EXISTS idx_ai_feedback_guild_id | ||
| ON ai_feedback(guild_id) | ||
| `); | ||
BillChirico marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| pgm.sql(` | ||
| CREATE INDEX IF NOT EXISTS idx_ai_feedback_message_id | ||
| ON ai_feedback(message_id) | ||
| `); | ||
| }; | ||
|
|
||
| /** @param {import('node-pg-migrate').MigrationBuilder} pgm */ | ||
| exports.down = (pgm) => { | ||
| pgm.sql(\`DROP INDEX IF EXISTS idx_ai_feedback_message_id\`); | ||
| pgm.sql(\`DROP INDEX IF EXISTS idx_ai_feedback_guild_id\`); | ||
| pgm.sql(\`DROP TABLE IF EXISTS ai_feedback\`); | ||
BillChirico marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,257 @@ | ||
| /** | ||
| * AI Feedback Routes | ||
| * Endpoints for reading AI response feedback (👍/👎) stats. | ||
| * | ||
| * Mounted at /api/v1/guilds/:id/ai-feedback | ||
| */ | ||
|
|
||
| import { Router } from 'express'; | ||
| import { error as logError } from '../../logger.js'; | ||
| import { rateLimit } from '../middleware/rateLimit.js'; | ||
| import { requireGuildAdmin, validateGuild } from './guilds.js'; | ||
|
|
||
| const router = Router({ mergeParams: true }); | ||
|
|
||
| /** Rate limiter: 60 requests / 1 min per IP */ | ||
| const feedbackRateLimit = rateLimit({ windowMs: 60 * 1000, max: 60 }); | ||
|
|
||
| // ── GET /stats ───────────────────────────────────────────────────────────── | ||
|
|
||
| /** | ||
| * @openapi | ||
| * /guilds/{id}/ai-feedback/stats: | ||
| * get: | ||
| * tags: | ||
| * - AI Feedback | ||
| * summary: Get AI feedback statistics | ||
| * description: Returns aggregate 👍/👎 feedback counts and daily trend for a guild. | ||
| * security: | ||
| * - ApiKeyAuth: [] | ||
| * - BearerAuth: [] | ||
| * parameters: | ||
| * - in: path | ||
| * name: id | ||
| * required: true | ||
| * schema: | ||
| * type: string | ||
| * description: Guild ID | ||
| * - in: query | ||
| * name: days | ||
| * schema: | ||
| * type: integer | ||
| * default: 30 | ||
| * minimum: 1 | ||
| * maximum: 90 | ||
| * description: Number of days for the trend window | ||
| * responses: | ||
| * "200": | ||
| * description: Feedback statistics | ||
| * content: | ||
| * application/json: | ||
| * schema: | ||
| * type: object | ||
| * properties: | ||
| * positive: | ||
| * type: integer | ||
| * negative: | ||
| * type: integer | ||
| * total: | ||
| * type: integer | ||
| * ratio: | ||
| * type: integer | ||
| * nullable: true | ||
| * description: Positive feedback percentage (0–100), or null if no feedback | ||
| * trend: | ||
| * type: array | ||
| * items: | ||
| * type: object | ||
| * properties: | ||
| * date: | ||
| * type: string | ||
| * format: date | ||
| * positive: | ||
| * type: integer | ||
| * negative: | ||
| * type: integer | ||
| * "401": | ||
| * $ref: "#/components/responses/Unauthorized" | ||
| * "403": | ||
| * $ref: "#/components/responses/Forbidden" | ||
| * "429": | ||
| * $ref: "#/components/responses/RateLimited" | ||
| * "500": | ||
| * $ref: "#/components/responses/ServerError" | ||
| * "503": | ||
| * $ref: "#/components/responses/ServiceUnavailable" | ||
| */ | ||
| router.get('/stats', feedbackRateLimit, requireGuildAdmin, validateGuild, async (req, res) => { | ||
BillChirico marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| const { dbPool } = req.app.locals; | ||
| if (!dbPool) { | ||
| return res.status(503).json({ error: 'Database not available' }); | ||
| } | ||
|
|
||
| const guildId = req.params.id; | ||
|
|
||
| let days = 30; | ||
| if (req.query.days !== undefined) { | ||
| const parsed = Number.parseInt(req.query.days, 10); | ||
| if (!Number.isNaN(parsed) && parsed >= 1 && parsed <= 90) { | ||
| days = parsed; | ||
| } | ||
| } | ||
|
|
||
| try { | ||
| const [statsResult, trendResult] = await Promise.all([ | ||
| dbPool.query( | ||
| `SELECT | ||
| COUNT(*) FILTER (WHERE feedback_type = 'positive')::int AS positive, | ||
| COUNT(*) FILTER (WHERE feedback_type = 'negative')::int AS negative, | ||
| COUNT(*)::int AS total | ||
| FROM ai_feedback | ||
| WHERE guild_id = $1`, | ||
| [guildId], | ||
| ), | ||
| dbPool.query( | ||
| `SELECT | ||
| DATE(created_at) AS date, | ||
| COUNT(*) FILTER (WHERE feedback_type = 'positive')::int AS positive, | ||
| COUNT(*) FILTER (WHERE feedback_type = 'negative')::int AS negative | ||
| FROM ai_feedback | ||
| WHERE guild_id = $1 | ||
| AND created_at >= NOW() - ($2 * interval '1 day') | ||
| GROUP BY DATE(created_at) | ||
| ORDER BY date ASC`, | ||
| [guildId, days], | ||
| ), | ||
BillChirico marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ]); | ||
BillChirico marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| const row = statsResult.rows[0]; | ||
| const positive = row?.positive || 0; | ||
| const negative = row?.negative || 0; | ||
| const total = row?.total || 0; | ||
| const ratio = total > 0 ? Math.round((positive / total) * 100) : null; | ||
|
|
||
| res.json({ | ||
| positive, | ||
| negative, | ||
| total, | ||
| ratio, | ||
| trend: trendResult.rows.map((r) => ({ | ||
| date: r.date, | ||
| positive: r.positive, | ||
| negative: r.negative, | ||
| })), | ||
| }); | ||
| } catch (err) { | ||
| logError('Failed to fetch AI feedback stats', { error: err.message, guild: guildId }); | ||
| res.status(500).json({ error: 'Failed to fetch AI feedback stats' }); | ||
| } | ||
| }); | ||
BillChirico marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // ── GET /recent ────────────────────────────────────────────────────────────── | ||
|
|
||
| /** | ||
| * @openapi | ||
| * /guilds/{id}/ai-feedback/recent: | ||
| * get: | ||
| * tags: | ||
| * - AI Feedback | ||
| * summary: Get recent feedback entries | ||
| * description: Returns the most recent feedback entries for a guild (newest first). | ||
| * security: | ||
| * - ApiKeyAuth: [] | ||
| * - BearerAuth: [] | ||
| * parameters: | ||
| * - in: path | ||
| * name: id | ||
| * required: true | ||
| * schema: | ||
| * type: string | ||
| * description: Guild ID | ||
| * - in: query | ||
| * name: limit | ||
| * schema: | ||
| * type: integer | ||
| * default: 25 | ||
| * maximum: 100 | ||
| * responses: | ||
| * "200": | ||
| * description: Recent feedback entries | ||
| * content: | ||
| * application/json: | ||
| * schema: | ||
| * type: object | ||
| * properties: | ||
| * feedback: | ||
| * type: array | ||
| * items: | ||
| * type: object | ||
| * properties: | ||
| * id: | ||
| * type: integer | ||
| * messageId: | ||
| * type: string | ||
| * channelId: | ||
| * type: string | ||
| * userId: | ||
| * type: string | ||
| * feedbackType: | ||
| * type: string | ||
| * enum: [positive, negative] | ||
| * createdAt: | ||
| * type: string | ||
| * format: date-time | ||
| * "401": | ||
| * $ref: "#/components/responses/Unauthorized" | ||
| * "403": | ||
| * $ref: "#/components/responses/Forbidden" | ||
| * "429": | ||
| * $ref: "#/components/responses/RateLimited" | ||
| * "500": | ||
| * $ref: "#/components/responses/ServerError" | ||
| * "503": | ||
| * $ref: "#/components/responses/ServiceUnavailable" | ||
| */ | ||
| router.get('/recent', feedbackRateLimit, requireGuildAdmin, validateGuild, async (req, res) => { | ||
BillChirico marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| const { dbPool } = req.app.locals; | ||
| if (!dbPool) { | ||
| return res.status(503).json({ error: 'Database not available' }); | ||
| } | ||
|
|
||
| const guildId = req.params.id; | ||
|
|
||
| let limit = 25; | ||
| if (req.query.limit !== undefined) { | ||
| const parsed = Number.parseInt(req.query.limit, 10); | ||
| if (!Number.isNaN(parsed) && parsed >= 1 && parsed <= 100) { | ||
| limit = parsed; | ||
| } | ||
| } | ||
|
|
||
| try { | ||
| const result = await dbPool.query( | ||
| `SELECT id, message_id, channel_id, user_id, feedback_type, created_at | ||
| FROM ai_feedback | ||
| WHERE guild_id = $1 | ||
| ORDER BY created_at DESC | ||
| LIMIT $2`, | ||
| [guildId, limit], | ||
| ); | ||
|
|
||
| res.json({ | ||
| feedback: result.rows.map((r) => ({ | ||
| id: r.id, | ||
| messageId: r.message_id, | ||
| channelId: r.channel_id, | ||
| userId: r.user_id, | ||
| feedbackType: r.feedback_type, | ||
| createdAt: r.created_at, | ||
| })), | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }); | ||
| } catch (err) { | ||
| logError('Failed to fetch recent AI feedback', { error: err.message, guild: guildId }); | ||
| res.status(500).json({ error: 'Failed to fetch recent AI feedback' }); | ||
| } | ||
| }); | ||
|
|
||
| export default router; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.