feat: Added indexing and search with dense vector#37
Conversation
|
Review task created: https://virtocommerce.atlassian.net/browse/VCST-4463 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
src/VirtoCommerce.ElasticSearch8.Data/Services/ElasticSearchRequestBuilder.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.ElasticSearch8.Data/Services/ElasticSearchRequestBuilder.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.ElasticSearch8.Data/Services/ElasticSearchPropertyService.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.ElasticSearch8.Data/Services/ElasticSearch8Provider.cs
Outdated
Show resolved
Hide resolved
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.587
Timestamp: 19-12-2025T14:50:14
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.789
Timestamp: 22-12-2025T13:01:20
src/VirtoCommerce.ElasticSearch8.Data/Services/ElasticSearchRequestBuilder.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.ElasticSearch8.Data/Services/ElasticSearchRequestBuilder.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.ElasticSearch8.Data/Services/ElasticSearchRequestBuilder.cs
Show resolved
Hide resolved
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.414
Timestamp: 26-12-2025T12:22:10
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.803
Timestamp: 26-12-2025T12:32:07
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.403
Timestamp: 14-01-2026T10:17:03
src/VirtoCommerce.ElasticSearch8.Data/Services/ElasticSearchPropertyService.cs
Show resolved
Hide resolved
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.685
Timestamp: 23-01-2026T11:01:06
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.811
Timestamp: 26-01-2026T13:11:36
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
src/VirtoCommerce.ElasticSearch8.Data/Services/ElasticSearchRequestBuilder.cs
Show resolved
Hide resolved
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.768
Timestamp: 26-01-2026T16:09:57
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.061
Timestamp: 26-01-2026T17:20:51
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.253
Timestamp: 27-01-2026T09:07:46
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.177
Timestamp: 27-01-2026T09:18:32
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.648
Timestamp: 27-01-2026T09:43:02
…stem ignores the global semantic model setting.
|
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.708
Timestamp: 05-02-2026T19:13:12
3 participants
Description
feat: Added indexing and search with dense vector
References
QA-test:
Jira-link:
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.ElasticSearch8_3.825.0-pr-37-99e8.zip
Note
Medium Risk
Touches core indexing/mapping and search query construction (kNN/semantic paths), so misconfiguration could lead to mapping mismatches or degraded search behavior; scope is localized and covered by updated tests/constructor wiring.
Overview
Adds dense vector support end-to-end:
ElasticSearchPropertyServicecan now create/configureDenseVectorProperty(dims from settings) andElasticSearch8Provideruses that configuration when creating the semantic__mlmapping.Indexing logic now detects documents already containing a dense vector field and skips semantic ML pipeline setup in that mode, while
ElasticSearchRequestBuildercan run kNN either from the configured text-embedding model or directly from a request-suppliedDenseVector, bypassing the global semantic search type when vectors are provided.Updates dependencies (
VirtoCommerce.SearchModule.Coreto3.824.0) and adjusts tests/DI wiring to injectISettingsManager/IElasticSearchPropertyServiceaccordingly.Written by Cursor Bugbot for commit 99e8efb. This will update automatically on new commits. Configure here.